Skip to content

When activation is missing, do not emit a log message#1

Merged
jpmelos merged 1 commit intocloseio-masterfrom
fix-flask-activation-missing-log-message
Dec 12, 2020
Merged

When activation is missing, do not emit a log message#1
jpmelos merged 1 commit intocloseio-masterfrom
fix-flask-activation-missing-log-message

Conversation

@jpmelos
Copy link
Member

@jpmelos jpmelos commented Dec 11, 2020

If a Flask request doesn't have an active span, it just means that it was initialized via a mechanism that doesn't run before_request, like app.test_request_context or even manually. It is okay and instrumentation still works.

@jpmelos jpmelos self-assigned this Dec 11, 2020
@jpmelos
Copy link
Member Author

jpmelos commented Dec 12, 2020

Ran tests in my local environment and all tests pass.

@jpmelos jpmelos merged commit 30c80fa into closeio-master Dec 12, 2020
@jpmelos jpmelos deleted the fix-flask-activation-missing-log-message branch December 12, 2020 18:00
@jpmelos
Copy link
Member Author

jpmelos commented Dec 12, 2020

Submitted this change upstream in open-telemetry#253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant