Skip to content

Run tests against LavinMQ and RabbitMQ#77

Draft
walro wants to merge 2 commits intomainfrom
tests-on-lavinmq
Draft

Run tests against LavinMQ and RabbitMQ#77
walro wants to merge 2 commits intomainfrom
tests-on-lavinmq

Conversation

@walro
Copy link
Contributor

@walro walro commented Mar 11, 2026

  • Run both brokers for all the standard test (invoked by bundle exec rake test)
  • Only use LavinMQ for TLS and macOS tests (to keep it simple)
  • Use RabbitMQ for tests that shell out to rabbitmqctl, there is no direct replacement in lavinmqctl

TODO: Doens't work today due to subtle differences in LavinMQ and RabbitMQ. Run with allow-failure for LavinMQ?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI to run the default test suite against LavinMQ, while isolating RabbitMQ-specific (sudo/rabbitmqctl) behavior into a separate test task and CI job.

Changes:

  • Switch GitHub Actions Linux/macOS broker setup from RabbitMQ to LavinMQ; add a dedicated RabbitMQ sudo test job.
  • Move blocked-connection (rabbitmqctl) tests out of the default AMQP lifecycle suite into test/rabbitmq/....
  • Update Rake test tasks to exclude RabbitMQ-specific tests from the default runs and add test:rabbitmq.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/test_helper.rb Removes global sudo-skip helper previously used by RabbitMQ-only tests.
test/amqp/client_lifecycle_test.rb Removes blocked-connection tests from the default suite.
test/rabbitmq/amqp/client_lifecycle_test.rb Adds RabbitMQ-only blocked-connection tests runnable via a dedicated task/job.
Rakefile Excludes RabbitMQ-specific tests from default tasks; adds test:rabbitmq.
.github/workflows/main.yml Uses LavinMQ for the main test matrix/TLS/macos; adds a RabbitMQ sudo job for RabbitMQ-only tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@walro walro force-pushed the tests-on-lavinmq branch 2 times, most recently from 28896ff to f83c436 Compare March 11, 2026 16:40
Except for the tests that explicitly use RabbitMQ.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@walro walro changed the title Run CI on LavinMQ instead of RabbitMQ Run CI on LavinMQ as well Mar 11, 2026
@walro walro changed the title Run CI on LavinMQ as well Run tests against LavinMQ and RabbitMQ Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants