Conversation
There was a problem hiding this comment.
Pull request overview
Updates CI to run the default test suite against LavinMQ, while isolating RabbitMQ-specific (sudo/rabbitmqctl) behavior into a separate test task and CI job.
Changes:
- Switch GitHub Actions Linux/macOS broker setup from RabbitMQ to LavinMQ; add a dedicated RabbitMQ sudo test job.
- Move blocked-connection (rabbitmqctl) tests out of the default AMQP lifecycle suite into
test/rabbitmq/.... - Update Rake test tasks to exclude RabbitMQ-specific tests from the default runs and add
test:rabbitmq.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
test/test_helper.rb |
Removes global sudo-skip helper previously used by RabbitMQ-only tests. |
test/amqp/client_lifecycle_test.rb |
Removes blocked-connection tests from the default suite. |
test/rabbitmq/amqp/client_lifecycle_test.rb |
Adds RabbitMQ-only blocked-connection tests runnable via a dedicated task/job. |
Rakefile |
Excludes RabbitMQ-specific tests from default tasks; adds test:rabbitmq. |
.github/workflows/main.yml |
Uses LavinMQ for the main test matrix/TLS/macos; adds a RabbitMQ sudo job for RabbitMQ-only tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
28896ff to
f83c436
Compare
Except for the tests that explicitly use RabbitMQ.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bundle exec rake test)rabbitmqctl, there is no direct replacement inlavinmqctlTODO: Doens't work today due to subtle differences in LavinMQ and RabbitMQ. Run with allow-failure for LavinMQ?