Skip to content

Use conventional priority for setting configurable values#202

Merged
kickster97 merged 5 commits intomainfrom
let_ENV_take_priority
Mar 21, 2025
Merged

Use conventional priority for setting configurable values#202
kickster97 merged 5 commits intomainfrom
let_ENV_take_priority

Conversation

@kickster97
Copy link
Member

@kickster97 kickster97 commented Mar 18, 2025

Today, the config variables are set in the priority order

  1. CLI arguments
  2. Config file
  3. ENV variables

This pr changes so the config variables are set in a conventional priority order

  1. CLI arguments
  2. ENV variables
  3. Config file

WIP,
Adresses questions in #192

@kickster97 kickster97 requested review from carlhoerberg and removed request for carlhoerberg March 20, 2025 12:04
@kickster97 kickster97 marked this pull request as ready for review March 21, 2025 09:44
@kickster97 kickster97 requested a review from a team as a code owner March 21, 2025 09:44
@kickster97 kickster97 changed the title wip use conventional priority for setting configurable values Use conventional priority for setting configurable values Mar 21, 2025
@kickster97 kickster97 merged commit 4c9512d into main Mar 21, 2025
4 checks passed
@kickster97 kickster97 deleted the let_ENV_take_priority branch March 21, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants