AvroEventFormatter in incorrect namespace

[squanbeck]

AvroEventFormatter is currently found in the CloudNative.CloudEvents namespace.

sdk-csharp/src/CloudNative.CloudEvents.Avro/AvroEventFormatter.cs

Lines 12 to 16 in 3ce4aa0

	using System.Net.Mime;
	namespace CloudNative.CloudEvents
	{
	/// <summary>

To keep things consistent, as with both protobuf and json (first two other examples I looked at), the AvroEventFormatter should be found in CloudNative.CloudEvents.Avro namespace.

Reference to SystemTextJson and Protobuf EventFormatters below.

sdk-csharp/src/CloudNative.CloudEvents.Protobuf/ProtobufEventFormatter.cs

Lines 18 to 22 in 3ce4aa0

	using static CloudNative.CloudEvents.V1.CloudEvent.Types.CloudEventAttributeValue;
	namespace CloudNative.CloudEvents.Protobuf
	{
	// TODO: Derived type which expects to only receive protobuf message data with a particular message type,

sdk-csharp/src/CloudNative.CloudEvents.SystemTextJson/JsonEventFormatter.cs

Lines 12 to 16 in 3ce4aa0

	using System.Threading.Tasks;
	namespace CloudNative.CloudEvents.SystemTextJson
	{
	/// <summary>

[jskeet]

Humbug. Yes, that absolutely should be in the CloudNative.CloudEvents.Avro namespace.

Unfortunately we can't remove it now without taking a new major version (at least for that package).

I suggest I make the existing formatter obsolete (but keep it as-is), and create a new copy in the right namespace. The old one won't get any new features etc.

Does that sound appropriate to you?

(I'll double check the rest at the same time...)

[squanbeck]

I was wondering if that might be the case. As far as I am concerned, that sounds perfectly appropriate. At this point, I was just beginning to look into CloudEvents, and so I don't have any current code that depends on this. I only found it due to some first looks at serializing/deserializing CloudEvents using the provided formatters. Thanks for the quick response!