Skip to content

Conversation

@denismakogon
Copy link
Member

This spec is the first step towards nicely-shaped CloudEvents SDK spec.

Signed-off-by: Denis Makogon <[email protected]>
@duglin
Copy link
Collaborator

duglin commented Nov 27, 2018

Overall, I think its a good first start. Aside from the comments I made in the file, could you:
1 - wrap things at 80 columns to be consistent with the other files in the repo
2 - add a pointer to this file from the main README so people can easily find it.

@duglin
Copy link
Collaborator

duglin commented Nov 27, 2018

For those who were not in our weekly SDK call today, we talked about how it would be nice to have a document that describes what is expected of new SDKs. That then led to the idea of it being a (sort of) high-level design doc - to push for consistency where possible.

@denismakogon agreed to take a first pass at it - which is this PR.

We don't have a global "SDK" repo for stuff like this - so for now we decided it put it in this repo. If we get more "common SDK" docs then we can consider creating a new repo for them to live in.

Signed-off-by: Denis Makogon <[email protected]>
Signed-off-by: Denis Makogon <[email protected]>
@duglin
Copy link
Collaborator

duglin commented Dec 5, 2018

SDKers - any comments/thoughts? Good enough for a first draft?


Time setter represents event emit time setter:
```
SetEventTime(time RFC3339)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use something like SetTime, since that actually matches the 0.2 bits ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather leave this as it is, the small bonus here is the verbosity, once 0.1 will be deprecated, we can switch to whatever that is.

@Vlaaaaaaad Vlaaaaaaad mentioned this pull request Dec 6, 2018
@duglin
Copy link
Collaborator

duglin commented Dec 6, 2018

Approved on the 12/6 call

@duglin duglin merged commit 36448a9 into cloudevents:master Dec 6, 2018
@denismakogon
Copy link
Member Author

Cool!

@denismakogon denismakogon deleted the sdk-spec branch December 6, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants