-
Notifications
You must be signed in to change notification settings - Fork 603
CloudEvents SDK spec proposal #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Denis Makogon <[email protected]>
ab46bdc to
75aa70c
Compare
|
Overall, I think its a good first start. Aside from the comments I made in the file, could you: |
|
For those who were not in our weekly SDK call today, we talked about how it would be nice to have a document that describes what is expected of new SDKs. That then led to the idea of it being a (sort of) high-level design doc - to push for consistency where possible. @denismakogon agreed to take a first pass at it - which is this PR. We don't have a global "SDK" repo for stuff like this - so for now we decided it put it in this repo. If we get more "common SDK" docs then we can consider creating a new repo for them to live in. |
Signed-off-by: Denis Makogon <[email protected]>
Signed-off-by: Denis Makogon <[email protected]>
|
SDKers - any comments/thoughts? Good enough for a first draft? |
|
|
||
| Time setter represents event emit time setter: | ||
| ``` | ||
| SetEventTime(time RFC3339) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use something like SetTime, since that actually matches the 0.2 bits ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather leave this as it is, the small bonus here is the verbosity, once 0.1 will be deprecated, we can switch to whatever that is.
|
Approved on the 12/6 call |
|
Cool! |
This spec is the first step towards nicely-shaped CloudEvents SDK spec.