Fixes #311 - Make timeouts Sync #312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
And once again intermittent test failures in unrelated code. This time it’s the random number generator: you cannot reliably test distribution of random results, there will be occasional outliers. 🙄 |
eaufavor
added
enhancement
andrewhavck
added
Accepted
eaufavor
pushed a commit
that referenced
this pull request
Jul 26, 2024
eaufavor
pushed a commit
that referenced
this pull request
Jul 26, 2024
eaufavor
pushed a commit
that referenced
this pull request
Jul 26, 2024
Contributor
Author
|
This landed apparently: 18db42c |
escoffier
pushed a commit
to escoffier/pingora
that referenced
this pull request
Sep 6, 2024
Includes-commit: 3faed99 Replicated-from: cloudflare#312
xxargonaut
added a commit
to xxargonaut/pingora
that referenced
this pull request
Feb 19, 2025
Includes-commit: 3faed99e264cda6ba3986912d06c6e67bf5df13b Replicated-from: cloudflare/pingora#312
xxargonaut
added a commit
to xxargonaut/pingora
that referenced
this pull request
Feb 19, 2025
Includes-commit: 3faed99e264cda6ba3986912d06c6e67bf5df13b Replicated-from: cloudflare/pingora#312
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
BoxFutureby the type it aliases while adding theSynctrait. See #311 for the rationale behind this change.