document early_request_filter #368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cloudflare#363 Signed-off-by: spacewander <[email protected]>
Collaborator
|
Other than the nit this LGTM. Thanks for helping with this! |
drcaramelsyrup
requested changes
Aug 30, 2024
docs/user_guide/phase.md
Outdated
| ### `early_request_filter()` | ||
| This is the first phase of every request. | ||
|
|
||
| This function is similar to `request_filter()` but execute before any other logic especially the downstream modules. |
Collaborator
There was a problem hiding this comment.
nit, I think putting the full purpose here too is helpful: executes before any other logic, including downstream module logic. The main purpose of this function is to provide finer-grained control of the behavior of the modules.
I know the wording is slightly different from the doc comment, we can get that cleaned up.
Signed-off-by: spacewander <[email protected]>
drcaramelsyrup
approved these changes
Sep 5, 2024
drcaramelsyrup
added
the
Accepted
gdavidsson
pushed a commit
that referenced
this pull request
Sep 13, 2024
Fix #363 --- updated Includes-commit: 204ddb0 Includes-commit: 34c67f0 Replicated-from: #368 Signed-off-by: spacewander <[email protected]>
gdavidsson
pushed a commit
that referenced
this pull request
Sep 13, 2024
Fix #363 --- updated Includes-commit: 204ddb0 Includes-commit: 34c67f0 Replicated-from: #368 Signed-off-by: spacewander <[email protected]>
Contributor
|
Synced thanks! |
xxargonaut
added a commit
to xxargonaut/pingora
that referenced
this pull request
Feb 19, 2025
Fix #363 --- updated Includes-commit: 204ddb02743445e6204858b4df3ea3f28fa1911c Includes-commit: 34c67f0acae52ce94a3a6d5696e0847e63b42be7 Replicated-from: cloudflare/pingora#368 Signed-off-by: spacewander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #363
Signed-off-by: spacewander [email protected]