Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Support state upgraders for resource
authenticated_origin_pulls/authenticated_origin_pulls_settingsandauthenticated_origin_pulls_certificate/authenticated_origin_pulls_hostname_certificateAcceptance test run results
Steps to run acceptance tests
authenticated_origin_pulls
``
authenticated_origin_pulls_certificate
TF_MIGRATE_BINARY_PATH=/Users/ssicard/workspace/terraform-devstack/tf-migrate/tf-migrate TF_ACC=1 go test ./internal/services/authenticated_origin_pulls_certificate/migration/v500 -vTest output
authenticated_origin_pulls
authenticated_origin_pulls_certificate
=== RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v4_latest === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v5 --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone (59.80s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v4_latest (23.85s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone/from_v5 (35.96s) === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v4_latest_minimal === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v5_minimal --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal (59.34s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v4_latest_minimal (40.66s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_Minimal/from_v5_minimal (18.67s) === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v4_latest_all_fields === RUN TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v5_all_fields --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields (61.56s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v4_latest_all_fields (29.24s) --- PASS: TestMigrateAuthenticatedOriginPullsCertificate_V4ToV5_PerZone_AllFields/from_v5_all_fields (32.32s) === RUN TestMigrateAuthenticatedOriginPullsHostnameCertificate_V4ToV5 --- PASS: TestMigrateAuthenticatedOriginPullsHostnameCertificate_V4ToV5 (30.16s) === RUN TestMigrateAuthenticatedOriginPullsHostnameCertificate_V4ToV5_Minimal --- PASS: TestMigrateAuthenticatedOriginPullsHostnameCertificate_V4ToV5_Minimal (36.70s) PASS ok github.com/cloudflare/terraform-provider-cloudflare/internal/services/authenticated_origin_pulls_certificate/migration/v500 249.036sAdditional context & links