Support i18n in the errors project#14
Support i18n in the errors project#14xingzhou wants to merge 2 commits intocloudfoundry-attic:masterfrom
Conversation
Add the translation files and the translation process description under the newly created i18n folder. The translation is used for the CC i18n enablement work, here is the first patchfor CC i18n enablement: cloudfoundry/cloud_controller_ng#267 Please refer to the README.md included in this patch for more information.
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/74283818. |
|
@xingzhou Hey looks good! Could you please remove the .DS_Store file? Thanks @leoRoss & @DanLavine |
|
@leoRoss & @DanLavine , thanks for the review, have removed the .DS_Store file from the PR. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/74354826. |
|
@MarkKropf Should we move this PR to Runtime's Tracker? CF Community Pair |
|
Yes, let's pull this in |
|
@xingzhou We don't think it is a good idea to copy all of the english language translations into the other language files. While it gives translators a point to start from, it is unlikely that all translation files will be updated correctly. Having 11 files that all diverge from each other would be confusing and hard to keep in sync. We think it would be best to have empty files for translations that do not yet exist (or even no files at all). The I18N library (in the Cloud Controller pull request) should be configured with a fall back to the english locale so if a translation does not exist, it will simply use the english. Also, it is confusing to have errors in both the english localization files and also in v2.yml. Since the messages in v2.yml are no longer used, it would make sense to remove them from there. And finally if you could squash any commits into a single one so the .DS_Store file and any other file histories don't make it into the repo. |
|
Hi @jpalermo, thanks for your comments!
|
|
@xingzhou yes, we're trying to avoid having to update more than one english translation every time a change is needed to keep the other files in sync. |
|
Ok, I can change to use an empty file, and according to the conversation in cloudfoundry/cloud_controller_ng#267, the message file structure will also be changed, will make new patch later |
|
@xingzhou Closing this PR as it's been a while with no activity. If you have a chance to make the requested changes and resubmit the PR we'll pull it in then. |
Add the translation files and the translation process description under
the newly created i18n folder.
The translation is used for the CC i18n enablement work, here is the first patchfor CC i18n enablement: cloudfoundry/cloud_controller_ng#267
Please refer to the README.md included in this patch for more information.