Skip to content
This repository was archived by the owner on Jan 25, 2022. It is now read-only.

Support i18n in the errors project#14

Closed
xingzhou wants to merge 2 commits intocloudfoundry-attic:masterfrom
xingzhou:support_i18n
Closed

Support i18n in the errors project#14
xingzhou wants to merge 2 commits intocloudfoundry-attic:masterfrom
xingzhou:support_i18n

Conversation

@xingzhou
Copy link
Contributor

@xingzhou xingzhou commented Jul 2, 2014

Add the translation files and the translation process description under
the newly created i18n folder.

The translation is used for the CC i18n enablement work, here is the first patchfor CC i18n enablement: cloudfoundry/cloud_controller_ng#267

Please refer to the README.md included in this patch for more information.

Add the translation files and the translation process description under
the newly created i18n folder.

The translation is used for the CC i18n enablement work, here is the first patchfor CC i18n enablement: cloudfoundry/cloud_controller_ng#267

Please refer to the README.md included in this patch for more information.
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/74283818.

@ghost
Copy link

ghost commented Jul 2, 2014

@xingzhou Hey looks good! Could you please remove the .DS_Store file?

Thanks

@leoRoss & @DanLavine
CF Community Pair

@xingzhou
Copy link
Contributor Author

xingzhou commented Jul 3, 2014

@leoRoss & @DanLavine , thanks for the review, have removed the .DS_Store file from the PR.

@xingzhou xingzhou closed this Jul 3, 2014
@xingzhou xingzhou reopened this Jul 3, 2014
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/74354826.

@ghost
Copy link

ghost commented Jul 3, 2014

@MarkKropf Should we move this PR to Runtime's Tracker?

CF Community Pair
@leoRoss & @DanLavine

@MarkKropf
Copy link

Yes, let's pull this in

@jpalermo
Copy link

@xingzhou We don't think it is a good idea to copy all of the english language translations into the other language files. While it gives translators a point to start from, it is unlikely that all translation files will be updated correctly. Having 11 files that all diverge from each other would be confusing and hard to keep in sync.

We think it would be best to have empty files for translations that do not yet exist (or even no files at all).

The I18N library (in the Cloud Controller pull request) should be configured with a fall back to the english locale so if a translation does not exist, it will simply use the english.

Also, it is confusing to have errors in both the english localization files and also in v2.yml. Since the messages in v2.yml are no longer used, it would make sense to remove them from there.

And finally if you could squash any commits into a single one so the .DS_Store file and any other file histories don't make it into the repo.

@xingzhou
Copy link
Contributor Author

Hi @jpalermo, thanks for your comments!
Here is what I'm thinking, for our discussion:

  1. It's ok for using empty message files for those languages not finish translation yet, but I use those file to keep it consistent with the original CLI I18n solution. If you think that we need to use the empty files, that would be fine to me.
  2. For the reason for keeping messages in v2.yml, as I'm thinking this vendor/erros messages are shared during different CF components, for those projects who is not i18n enabled, they are still using the origin messages, so I keep the messages in v2.yml in case they are still working. A second reason for doing this is that, when we add new error message or the error message translation is missing in both English and the target language locale, we can still ensure that we can find it in the v2.yml.
  3. for the .DS_Store file, I think I've removed it in the second commit, do we need to only submit only one commit per PR? thanks for your information!

@MarkKropf
Copy link

@xingzhou yes, we're trying to avoid having to update more than one english translation every time a change is needed to keep the other files in sync.

@xingzhou
Copy link
Contributor Author

Ok, I can change to use an empty file, and according to the conversation in cloudfoundry/cloud_controller_ng#267, the message file structure will also be changed, will make new patch later

@dieucao
Copy link

dieucao commented Sep 10, 2014

@xingzhou Closing this PR as it's been a while with no activity. If you have a chance to make the requested changes and resubmit the PR we'll pull it in then.

@dieucao dieucao closed this Sep 10, 2014
@xingzhou xingzhou deleted the support_i18n branch September 10, 2014 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants