Conversation
- Enable Graceful shutdown, and use JDK 11 as default
|
@scottfrederick , can you kindly give a view of the PR? Thanks. |
|
@ywei2017 Thanks for the ideas. This PR includes several distinct unrelated changes, and I'm not inclined to accept them all as submitted. What's the motivation for making Java 11 the default in Likewise, it is better to let the platform choose the Java Buildpack to use instead of forcing The The health check and shutdown changes in |
|
@scottfrederick, thanks for the quick response.
If you are cool with the proposal, I will update the commit. Thanks |
|
@scottfrederick I made some of the suggested changes, and commented out some of optional settings for the manifest.yml. Let me know how you think. Thanks |
|
@scottfrederick - Is the PR still worthy of merging? If so, I will resolve the conflict. If not, I will delete it. |
A few minor touches -- using JDK 11 as default, graceful shutdown, and http healthcheck.
Thanks
Yansheng