Skip to content

Conversation

@max-zilla
Copy link
Contributor

No longer allow changing of filename or MIME type when file version changes.

Adds version parameter to file download endpoint.

Some fixes to heartbeat container for docker-compose.dev.

@max-zilla max-zilla requested a review from a team February 15, 2023 14:13
@ddey2
Copy link
Member

ddey2 commented Feb 15, 2023

@max-zilla Your code looks good to me for the issues addressed in the description. I am testing it.

One question - Can somebody download the older file version metadata from this as suggested in the title? I didn't see the respective code for that.

@max-zilla max-zilla marked this pull request as ready for review February 16, 2023 14:24
@max-zilla max-zilla requested a review from lmarini as a code owner February 16, 2023 14:24
@max-zilla
Copy link
Contributor Author

@max-zilla Your code looks good to me for the issues addressed in the description. I am testing it.

One question - Can somebody download the older file version metadata from this as suggested in the title? I didn't see the respective code for that.

the API already had support for that, it turns out. i don't have a frontend implementation yet.

@longshuicy longshuicy self-requested a review as a code owner February 16, 2023 18:11
@ddey2 ddey2 self-requested a review February 16, 2023 18:46
@longshuicy longshuicy merged commit 542dfb5 into main Feb 16, 2023
@max-zilla max-zilla deleted the 303-download-older-file-versions branch July 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants