Skip to content

Conversation

@tcnichol
Copy link
Contributor

fixes the missing metadata button.

@tcnichol tcnichol requested a review from longshuicy as a code owner January 18, 2024 15:54
@tcnichol tcnichol linked an issue Jan 18, 2024 that may be closed by this pull request
@tcnichol tcnichol requested review from ddey2 and lmarini January 18, 2024 15:54
Copy link
Member

@ddey2 ddey2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tcnichol
Copy link
Contributor Author

The metadata button was missing since setEnableAddMetadata should not have been added to the conditional for the button. It starts false and will be set to true by the button.

@longshuicy
Copy link
Member

After I created some user metadata and then click "add metadata" it leads me to a blank page
image
image

@tcnichol
Copy link
Contributor Author

@longshuicy

I have not been able to replicate the blank screen after add metadata.

I tried to replicate the same situation - metadata type abstract and metadata text field, but it worked for me and the new metadata was added to the dataset.

# Conflicts:
#	frontend/src/components/datasets/Dataset.tsx
@tcnichol
Copy link
Contributor Author

tcnichol commented Feb 1, 2024

I am able to replicate the blank screen error. Working to fix.

not datasetRole.role
That will break if it is undefined
@tcnichol
Copy link
Contributor Author

tcnichol commented Feb 1, 2024

I think I fixed the empty screen problem after clicking add metadata.

datasetRole !== undefined works
datasetRole.role !== undefined does not, since you can't get .role from undefined.

@longshuicy longshuicy merged commit bc85a42 into main Feb 2, 2024
@longshuicy longshuicy deleted the 887-add-metadata-button-now-missing branch February 2, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add metadata button now missing

4 participants