-
Notifications
You must be signed in to change notification settings - Fork 6
add metadata button is back #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ddey2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
|
The metadata button was missing since setEnableAddMetadata should not have been added to the conditional for the button. It starts false and will be set to true by the button. |
|
I have not been able to replicate the blank screen after add metadata. I tried to replicate the same situation - metadata type abstract and metadata text field, but it worked for me and the new metadata was added to the dataset. |
# Conflicts: # frontend/src/components/datasets/Dataset.tsx
|
I am able to replicate the blank screen error. Working to fix. |
not datasetRole.role That will break if it is undefined
|
I think I fixed the empty screen problem after clicking add metadata. datasetRole !== undefined works |


fixes the missing metadata button.