Skip to content

Allow Symfony 8; converted config to PHP#57

Merged
cmen merged 6 commits intocmen:masterfrom
knallcharge:master
Jan 2, 2026
Merged

Allow Symfony 8; converted config to PHP#57
cmen merged 6 commits intocmen:masterfrom
knallcharge:master

Conversation

@knallcharge
Copy link
Copy Markdown
Contributor

may need a new major version as PHP was bumped to ^8.4

@alexandre-castelain
Copy link
Copy Markdown

Thanks for this PR ! :)

@knallcharge
Copy link
Copy Markdown
Contributor Author

I reverted the bump to PHP 8.4 as composer.json still allows older Symfony-versions. You may consider issuing a new major that drops old Symfony- and PHP-versions, but I kept the same code running with Symfony 6-8 and PHP 8.1-8.5 without any problems so you may as well stick with the current composer.json :)

@alexandre-castelain
Copy link
Copy Markdown

Yeah, but I want to use the PHP configuration file, because the xml loader is deprecated ! :)

@knallcharge
Copy link
Copy Markdown
Contributor Author

Dind't check, but wouldn't the PHP-loader also work with the older Symfony/PHP-versions? Anyhow whatever number the new version may have, I'll use it ;)

@cmen
Copy link
Copy Markdown
Owner

cmen commented Jan 1, 2026

@knallcharge Sorry for the delay, I only just saw your PR.

Indeed, we have to stay compatible with older Symfony versions.

Some checks have failed. There are a couple of things to address before we can merge:

  • Code Analysis: Please remove the ignoreErrors line from the phpstan.neon.dist file.
  • Code Style: The code needs to be linted using PHP-CS-Fixer. You can find the instructions here.

Once these changes are made, I'll release a new minor version ;)

@cmen cmen self-requested a review January 1, 2026 11:00
@knallcharge
Copy link
Copy Markdown
Contributor Author

knallcharge commented Jan 2, 2026

@cmen Errors should be fixed :)
(can I trigger a new build myself to verify the changes?)

@cmen
Copy link
Copy Markdown
Owner

cmen commented Jan 2, 2026

@knallcharge
I’ve updated the repository settings to allow workflows for external contributors. To trigger a new build and verify your changes, push a new commit (even an empty one) or rebase your branch.

@cmen
Copy link
Copy Markdown
Owner

cmen commented Jan 2, 2026

I added a missing return type. All is good now. Let's go for the merge 🚀

@cmen cmen merged commit 92efca4 into cmen:master Jan 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants