Allow Symfony 8; converted config to PHP#57
Conversation
|
Thanks for this PR ! :) |
|
I reverted the bump to PHP 8.4 as composer.json still allows older Symfony-versions. You may consider issuing a new major that drops old Symfony- and PHP-versions, but I kept the same code running with Symfony 6-8 and PHP 8.1-8.5 without any problems so you may as well stick with the current composer.json :) |
|
Yeah, but I want to use the PHP configuration file, because the xml loader is deprecated ! :) |
|
Dind't check, but wouldn't the PHP-loader also work with the older Symfony/PHP-versions? Anyhow whatever number the new version may have, I'll use it ;) |
|
@knallcharge Sorry for the delay, I only just saw your PR. Indeed, we have to stay compatible with older Symfony versions. Some checks have failed. There are a couple of things to address before we can merge:
Once these changes are made, I'll release a new minor version ;) |
|
@cmen Errors should be fixed :) |
|
@knallcharge |
|
I added a missing return type. All is good now. Let's go for the merge 🚀 |
may need a new major version as PHP was bumped to ^8.4