feat: add extended thinking support for AWS Bedrock, Anthropic, and Vertex AI Claude 4+ models#20
Merged
sriaradhyula merged 1 commit intomainfrom Oct 7, 2025
Conversation
…ertex AI Claude 4+ models Add environment variables for configuring extended thinking: - AWS_BEDROCK_THINKING_ENABLED, AWS_BEDROCK_THINKING_BUDGET - ANTHROPIC_THINKING_ENABLED, ANTHROPIC_THINKING_BUDGET - VERTEXAI_THINKING_ENABLED, VERTEXAI_THINKING_BUDGET Default budget: 1024 tokens (minimum), automatically clamped to max_tokens if provided. Handles parameter incompatibilities (temperature, top_p, top_k). Includes 45 comprehensive tests covering all aspects. Fixes model_kwargs clobbering bug where response_format would overwrite thinking config. Now properly merges instead of replacing, preserving all configurations. Signed-off-by: Adam Dickinson <adickinson72@gmail.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
🧪 Google Gemini Test Results✅ Google Gemini Examples: PASS |
🧪 GCP Vertex AI Test Results✅ GCP Vertex AI Examples: PASS |
🧪 AWS Bedrock Test Results✅ AWS Bedrock Examples: PASS |
🧪 Azure OpenAI Test Results✅ Azure OpenAI Examples: PASS |
|
🧪 OpenAI Test Results❌ OpenAI Examples: FAIL |
1 similar comment
🧪 OpenAI Test Results❌ OpenAI Examples: FAIL |
Member
|
OpenAI deprecated some models. We need to remove gpt-4o, gpt-4.1 from our testcases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds extended thinking support for Claude 4+ models across AWS Bedrock, Anthropic, and Vertex AI providers.
Features
AWS_BEDROCK_THINKING_ENABLED,AWS_BEDROCK_THINKING_BUDGETANTHROPIC_THINKING_ENABLED,ANTHROPIC_THINKING_BUDGETVERTEXAI_THINKING_ENABLED,VERTEXAI_THINKING_BUDGETBug Fixes
model_kwargsclobbering bug whereresponse_formatwould overwritethinkingconfigTests
✅ 147 comprehensive tests passing, covering:
Documentation
Architectural Decision
After extensive analysis, we decided to:
This maintains clean separation of concerns: factory handles model configuration, agents handle runtime orchestration.
Why New PR?
Previous PR #19 was from my fork and had CI permission issues. Now that I'm a maintainer, creating PR from main repo branch for proper permissions.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com