Merged
Conversation
lucksus
requested changes
Apr 4, 2024
Member
lucksus
left a comment
There was a problem hiding this comment.
I didn't want to block this PR only because of the env var thing, but if we have more changes then that should be improved as well.
But the main change request I have is, not having a good portion of added lines be the same
let agent_instance = AgentService::instance();
let agent_service = agent_instance.lock().expect("agent lock");
let agent_ref: &AgentService = agent_service.as_ref().expect("agent instance");over and over again. Adding something like Ad4mDb::with_global_instance() to AgentService (or all our singletons) will reduce noice and deadlock risk.
…nstance to improve code readabiliy
lucksus
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.