Merged
Conversation
fayeed
previously approved these changes
Jun 21, 2024
jhweir
approved these changes
Jun 24, 2024
Contributor
jhweir
left a comment
jhweir
left a comment
There was a problem hiding this comment.
ChatGPT's nitpicking suggests it would be would be more "idiomatic and concise" to use &wrapped_s and &fixed_s instead of wrapped_s.as_str() and fixed_s.as_str() on lines 16 and 21 of rust-executor/src/perspectives/utils.rs, otherwise looks good XD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flux escapes apostrophes "'" with a backslash "'" which is not a valid JSON escape sequence. We have handcrafted code that turns Prolog results into JSON. With these "'" it failed to produce valid JSON. This fixes that.