Skip to content

Fix problems with Subject Classes#521

Merged
lucksus merged 5 commits intodevfrom
fix-isinstance
Sep 2, 2024
Merged

Fix problems with Subject Classes#521
lucksus merged 5 commits intodevfrom
fix-isinstance

Conversation

@fayeed
Copy link
Copy Markdown
Contributor

@fayeed fayeed commented Aug 23, 2024

  • Improve isSubjectInstance method with retry logic for better reliability
  • Fix addSdna() to not omit adding a new SDNA definition if the same name was added by someone else (which breaks use-case of some other non progenitor agent adding a subject class for them, which we won't run because not signed by a trustet agent, but we don't get out of that situation because we can't add it with our signature since the old implementation doesn't regard the author of the SDNA, but just finds it existing already)

@fayeed fayeed changed the title chore: Improve isSubjectInstance method with retry logic for better r… chore: Improve isSubjectInstance method with retry logic for better reliability Aug 23, 2024
Copy link
Copy Markdown
Member

@lucksus lucksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just need a changelog entry and then merge this!

@lucksus lucksus merged commit 8661001 into dev Sep 2, 2024
@lucksus lucksus changed the title chore: Improve isSubjectInstance method with retry logic for better reliability Fix problems with Subject Classes Sep 2, 2024
@lucksus lucksus deleted the fix-isinstance branch August 22, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants