Merged
Conversation
This reverts commit 1c50d02.
jhweir
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for long messages in Flux (and any subject class properties with values longer than 1000 characters) being broken was the
max_depthsetting in the output/printer code in Scryer that we had added last year. They have updated and improved that by now in their dev branch. So this jumps back to using our Scryer fork which I have recently updated to their latest dev version.The added test in here shows that long strings can now be handled without problem (same test failed with the old version).
Scryer now returns some strings as atoms, so we include those in results now too.