Skip to content

Timeout fallback added to linkAdded function in useSubjects hook #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucksus merged 2 commits into from
Dec 17, 2024
Merged

Timeout fallback added to linkAdded function in useSubjects hook #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c7fd39
Timeout fallback added to linkAdded function in useSubjects hook
jhweir Dec 17, 2024
8f1c092
Changelog entry
jhweir Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ This project _loosely_ adheres to [Semantic Versioning](https://semver.org/spec/
- Avoid high CPU load when idling by deactivating V8's code optimization [PR#531](https://github.com/coasys/ad4m/pull/531)
- Enable high-throughput of perspective mutations by debouncing commits to link languages and coalesce them into aggregated perspective diffs [PR#533](https://github.com/coasys/ad4m/pull/533)
- Fix for long Flux messages (and too long subject class properties in general) being broken [PR#538](https://github.com/coasys/ad4m/pull/538)
- Fix for missing links: timeout added to useSubjects function 'linkAdded' that fetches all data after one second gap between new links propagating [PR#540](https://github.com/coasys/ad4m/pull/540)

### Added
- Prolog predicates needed in new Flux mention notification trigger:
Expand Down
7 changes: 5 additions & 2 deletions ad4m-hooks/react/src/useSubjects.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState, useCallback, useEffect, useMemo } from "react";
import { useState, useCallback, useEffect, useMemo, useRef } from "react";
import {
getCache,
setCache,
Expand All @@ -24,6 +24,7 @@ export function useSubjects<SubjectClass>(props: Props<SubjectClass>) {
const [error, setError] = useState<string | undefined>(undefined);
const [isLoading, setIsLoading] = useState(false);
const { perspective, source, subject } = props;
const timeout = useRef<any>(null);

// Create cache key for entry
const cacheKey = `${perspective.uuid}/${source || ""}/${
Expand Down Expand Up @@ -92,7 +93,9 @@ export function useSubjects<SubjectClass>(props: Props<SubjectClass>) {
}

async function linkAdded(link: LinkExpression) {
const allEntries = (getCache(cacheKey) || []) as SubjectClass[];
if (timeout.current) clearTimeout(timeout.current);
timeout.current = setTimeout(getData, 1000);

const isNewEntry = link.data.source === source;
// @ts-ignore
const isUpdated = allEntries?.find((e) => e.id === link.data.source);
Expand Down