Rename SubjectEntity to Ad4mModel and adjust decorator names#579
Merged
Rename SubjectEntity to Ad4mModel and adjust decorator names#579
Conversation
jhweir
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename SubjectEntity to Ad4mModel and Update Decorator Names
Overview
This PR renames the
SubjectEntityclass toAd4mModeland updates related decorator names to use more intuitive and consistent terminology. These changes aim to make the codebase more approachable and better reflect the actual concepts being represented.Key Changes
Class Renaming
SubjectEntitytoAd4mModelto better represent its role as the base class for data models in AD4MSubjectQueryBuildertoModelQueryBuilderfor consistencyDecorator Updates
@SubjectProperty→@Property@SubjectOptional→@Optional@SubjectReadOnly→@ReadOnly@SubjectCollection→@Collection@SubjectFlag→@Flag@SubjectOptions→@ModelOptionsDocumentation Improvements