Skip to content

Fix escaping of expression content#597

Merged
lucksus merged 5 commits intodevfrom
hotfix/expression-escaping-flux-message-url
Apr 14, 2025
Merged

Fix escaping of expression content#597
lucksus merged 5 commits intodevfrom
hotfix/expression-escaping-flux-message-url

Conversation

@lucksus
Copy link
Copy Markdown
Member

@lucksus lucksus commented Apr 11, 2025

Fixes Flux messages with URLs

Summary by CodeRabbit

  • Bug Fixes
    • Resolved issues with expression content escaping in Flux messages containing URLs and mentions.
    • Fixed system freeze caused by incorrect passphrase handling during unlock.
  • New Features
    • Introduced a cache-map to optimize query performance for Perspectives with large embedding vectors.
  • Enhancements
    • Improved password entry during setup with reentry and clearer explanatory text.

Fixes Flux messages with URLs
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2025

Walkthrough

This change updates how JSON values are converted to strings in the resolve_property_value method of the PerspectiveInstance struct. The previous implementation used a match statement to differentiate string values, while the new approach directly utilizes serde_json::to_string(value) for serialization. This simplifies the code and introduces error handling that expects serialization to always succeed.

Changes

File Path Change Summary
rust-executor/src/.../perspective_instance.rs Simplified JSON value serialization using serde_json::to_string(value) and added error handling.

Sequence Diagram(s)

sequenceDiagram
    participant P as PerspectiveInstance
    participant S as serde_json
    P->>S: Call to_string(value)
    S-->>P: Return serialized JSON string
    Note right of P: Returned value used in resolve_property_value
Loading

Poem

Oh, I’m a rabbit with a skip and a hop,
Witnessing code changes that just won't stop.
JSON strings now gleam with a single call,
Simplified and safe, standing proud and tall.
🐇 Happy code trails, may bugs forever drop!

Let’s celebrate with a bounce and a cheer!
Coding magic is so very clear!

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4949797 and 67b5048.

📒 Files selected for processing (1)
  • CHANGELOG (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab95ae8 and 5699874.

📒 Files selected for processing (1)
  • rust-executor/src/perspectives/perspective_instance.rs (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
rust-executor/src/perspectives/perspective_instance.rs (4)
rust-executor/src/perspectives/utils.rs (2)
  • serde_json (11-11)
  • serde_json (16-16)
rust-executor/src/pubsub.rs (1)
  • serde_json (86-86)
rust-executor/src/db.rs (11)
  • serde_json (1568-1568)
  • serde_json (1637-1637)
  • serde_json (1678-1678)
  • serde_json (1712-1712)
  • serde_json (1768-1768)
  • serde_json (1815-1815)
  • serde_json (1865-1865)
  • serde_json (1908-1908)
  • serde_json (1972-1972)
  • serde_json (2006-2006)
  • serde_json (2040-2040)
rust-executor/src/types.rs (1)
  • to_string (460-464)

lucksus and others added 4 commits April 12, 2025 00:23
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@lucksus lucksus merged commit 51d5fb5 into dev Apr 14, 2025
3 checks passed
@lucksus lucksus deleted the hotfix/expression-escaping-flux-message-url branch August 22, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant