Send more inits for query subscriptions (10s - 25s)#604
Conversation
WalkthroughThe update expands the set of delay intervals used for sending initial subscription updates in the Prolog query subscription logic. Additional longer delays have been added, extending the timing over which initial "#init#" updates are sent to subscribers. The changes are confined to the internal logic of the subscription process. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
We are still seeing cases where query subscriptions fail to initialise and timeout. This can only happen if for some reason they missed the first initailistion response. Since we now have a way to distinguish init responses from regular ones, there is no problem with just sending more inits after longer wait periods, in order to fetch-up any query client that for any reason (maybe during loading the app was not yet there...) didn't get previous ones.
Summary by CodeRabbit