Skip to content

Send more inits for query subscriptions (10s - 25s)#604

Merged
lucksus merged 1 commit intodevfrom
feature/more-subscription-inits
May 9, 2025
Merged

Send more inits for query subscriptions (10s - 25s)#604
lucksus merged 1 commit intodevfrom
feature/more-subscription-inits

Conversation

@lucksus
Copy link
Member

@lucksus lucksus commented May 7, 2025

We are still seeing cases where query subscriptions fail to initialise and timeout. This can only happen if for some reason they missed the first initailistion response. Since we now have a way to distinguish init responses from regular ones, there is no problem with just sending more inits after longer wait periods, in order to fetch-up any query client that for any reason (maybe during loading the app was not yet there...) didn't get previous ones.

Summary by CodeRabbit

  • Refactor
    • Extended the timing intervals for sending initial subscription updates to subscribers, resulting in updates being spaced out over a longer period. No visible changes to user interface or interaction.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 7, 2025

Walkthrough

The update expands the set of delay intervals used for sending initial subscription updates in the Prolog query subscription logic. Additional longer delays have been added, extending the timing over which initial "#init#" updates are sent to subscribers. The changes are confined to the internal logic of the subscription process.

Changes

File(s) Change Summary
rust-executor/src/perspectives/perspective_instance.rs Extended the list of delay intervals for initial subscription updates to include 15000ms, 20000ms, and 25000ms. No changes to public interfaces.

Poem

A hop, a skip, a longer wait,
More time for queries to gestate.
With delays now stretched and wide,
The updates come, but not in stride.
So Prolog bunnies, take a seat,
Your answers soon, though not as fleet! 🐇⏳


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 00d6bf7 and 387413c.

📒 Files selected for processing (1)
  • rust-executor/src/perspectives/perspective_instance.rs (2 hunks)
🔇 Additional comments (2)
rust-executor/src/perspectives/perspective_instance.rs (2)

2062-2062: Extended delay intervals for existing subscription updates.

The change adds longer delays (15s, 20s, 25s) for sending initialization messages to existing subscriptions, which should help clients that might take longer to process the earlier messages.


2091-2091: Extended delay intervals for new subscription updates.

The change adds consistent delay intervals for new subscriptions, matching those used for existing subscriptions. This ensures uniform behavior for both newly created and existing subscriptions.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lucksus lucksus merged commit b58908c into dev May 9, 2025
3 checks passed
@lucksus lucksus deleted the feature/more-subscription-inits branch August 22, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant