Skip to content

Entry instances preserved in useModel hook when making the base expre…#617

Merged
lucksus merged 1 commit intodevfrom
use-model-instance-preservation
Aug 21, 2025
Merged

Entry instances preserved in useModel hook when making the base expre…#617
lucksus merged 1 commit intodevfrom
use-model-instance-preservation

Conversation

@jhweir
Copy link
Contributor

@jhweir jhweir commented Jul 17, 2025

Bug fix for useModel hook in @coasys/ad4m-vue-hooks

Model instances are now preserved when making the baseExpression property enumerable so hidden properties and functions remain accessible in the returned results.

Previously we added the baseExpression property to a new object that spread the entries properties, loosing hidden properties and methods on the instance.

Summary by CodeRabbit

  • Refactor
    • Improved internal handling of data properties to ensure certain fields are now properly included when viewing or interacting with model entries. No changes to user-facing features or workflows.

…ssion enumerable so hidden properties and functions remain accessible
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2025

Walkthrough

The update reorganizes import statements and adjusts formatting for type annotations in the useModel.ts file. The main change modifies the includeBaseExpressions function to use Object.defineProperty for making the baseExpression property enumerable on existing objects, instead of creating new shallow copies.

Changes

File(s) Change Summary
ad4m-hooks/vue/src/useModel.ts Reordered imports, reformatted a type annotation, and changed includeBaseExpressions to use Object.defineProperty for property enumerability.

Poem

In the warren of code, imports realigned,
A property now shines, enumerable, defined.
No new objects spawned, just traits revealed—
With defineProperty, intentions unsealed.
The model hops forward, neat and precise,
A rabbit’s delight: concise and nice! 🐇

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b052d73 and 649f3a3.

📒 Files selected for processing (1)
  • ad4m-hooks/vue/src/useModel.ts (3 hunks)

@lucksus lucksus merged commit d7f9dd6 into dev Aug 21, 2025
3 checks passed
@lucksus lucksus deleted the use-model-instance-preservation branch August 22, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants