Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe changes systematically update TypeScript import paths across 40+ files to reference versioned v135 CDN paths for type dependencies (primarily Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
bootstrap-languages/p-diff-sync/telepresenceAdapter.ts (1)
1-1: Clean up double semicolon on updated importThe switch to the v135 Ad4m type import looks correct, but there’s an extra
;at the end of the line. It’s harmless at runtime but could trip style checks; consider trimming it:-import type { TelepresenceAdapter, OnlineAgent, PerspectiveExpression, TelepresenceSignalCallback, HolochainLanguageDelegate, LanguageContext } from "https://esm.sh/v135/@perspect3vism/ad4m@0.5.0";; +import type { TelepresenceAdapter, OnlineAgent, PerspectiveExpression, TelepresenceSignalCallback, HolochainLanguageDelegate, LanguageContext } from "https://esm.sh/v135/@perspect3vism/ad4m@0.5.0";bootstrap-languages/embedding-vector-language/index.ts (1)
1-5: esm.sh/v135 imports for ad4m, pako, and base64-js are consistent with existing usageImports are correctly pinned and match how
pakoandbase64-jsare used incompressUri/decompressUri; I don’t see behavioral changes here.Optionally, consider standardizing on a single
pakoversion across the repo for simplicity, but it’s not required for this PR. Please also confirm your Deno build/tests pass with the new v135 endpoints.bootstrap-languages/centralized-p-diff-sync/telepresenceAdapter.ts (1)
1-3: Pinned esm.sh imports look fine; minor trailing semicolon nitThe switches to
https://esm.sh/v135/@perspect3vism/ad4m@0.5.0andhttps://esm.sh/v135/socket.io-client@4.7.2are consistent with the rest of the PR and should not affect behavior. If you touch this file again, you might drop the extra;at the end of Line 1, but it’s purely cosmetic.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
deno.lockis excluded by!**/*.lock
📒 Files selected for processing (34)
bootstrap-languages/agent-language/adapter.ts(1 hunks)bootstrap-languages/agent-language/index.ts(1 hunks)bootstrap-languages/centralized-agent-language/adapter.ts(1 hunks)bootstrap-languages/centralized-agent-language/index.ts(1 hunks)bootstrap-languages/centralized-file-storage/adapter.ts(1 hunks)bootstrap-languages/centralized-file-storage/index.ts(1 hunks)bootstrap-languages/centralized-p-diff-sync/index.ts(1 hunks)bootstrap-languages/centralized-p-diff-sync/linksAdapter.ts(1 hunks)bootstrap-languages/centralized-p-diff-sync/telepresenceAdapter.ts(1 hunks)bootstrap-languages/direct-message-language/adapter.ts(1 hunks)bootstrap-languages/direct-message-language/index.ts(1 hunks)bootstrap-languages/eas/adapter.ts(1 hunks)bootstrap-languages/eas/index.ts(1 hunks)bootstrap-languages/embedding-vector-language/index.ts(1 hunks)bootstrap-languages/file-storage/adapter.ts(1 hunks)bootstrap-languages/file-storage/file-storage.ts(1 hunks)bootstrap-languages/file-storage/index.ts(1 hunks)bootstrap-languages/file-storage/putAdapter.ts(1 hunks)bootstrap-languages/file-storage/types.ts(1 hunks)bootstrap-languages/language-language/adapter.ts(1 hunks)bootstrap-languages/language-language/index.ts(1 hunks)bootstrap-languages/language-language/languageAdapter.ts(1 hunks)bootstrap-languages/language-language/putAdapter.ts(1 hunks)bootstrap-languages/neighbourhood-language/adapter.ts(1 hunks)bootstrap-languages/neighbourhood-language/index.ts(1 hunks)bootstrap-languages/p-diff-sync/index.ts(1 hunks)bootstrap-languages/p-diff-sync/linksAdapter.ts(1 hunks)bootstrap-languages/p-diff-sync/telepresenceAdapter.ts(1 hunks)bootstrap-languages/perspective-language/adapter.ts(1 hunks)bootstrap-languages/perspective-language/index.ts(1 hunks)bootstrap-languages/perspective-language/putAdapter.ts(1 hunks)tests/js/languages/note-store/index.ts(1 hunks)tests/js/languages/test-language/index.ts(1 hunks)tests/js/scripts/get-builtin-test-langs.js(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- bootstrap-languages/agent-language/adapter.ts
- bootstrap-languages/neighbourhood-language/adapter.ts
- bootstrap-languages/file-storage/file-storage.ts
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-17T16:34:09.725Z
Learnt from: jhweir
Repo: coasys/ad4m PR: 617
File: ad4m-hooks/vue/src/useModel.ts:45-56
Timestamp: 2025-07-17T16:34:09.725Z
Learning: In ad4m-hooks/vue/src/useModel.ts, the baseExpression property is defined as a getter on the Ad4mModel prototype, not as an own property on individual instances. The current implementation correctly uses Object.defineProperty to create enumerable own properties that shadow the prototype getter, which is the appropriate approach for making prototype accessors enumerable.
Applied to files:
bootstrap-languages/centralized-agent-language/adapter.tsbootstrap-languages/eas/adapter.tsbootstrap-languages/file-storage/types.ts
🔇 Additional comments (28)
bootstrap-languages/perspective-language/adapter.ts (1)
1-1: Import URL bump to v135 looks consistentThe updated
esm.shURL (v135 +@perspect3vism/ad4m@0.5.0) is syntactically correct and matches the pattern used elsewhere in this PR. Please just confirm Deno builds/tests forperspective-languagesucceed against the new CDN endpoint.bootstrap-languages/p-diff-sync/index.ts (1)
1-1: Type import migration to v135 is fineThe Ad4m type import now targets the v135
esm.shURL while keeping the same@perspect3vism/ad4m@0.5.0version. This is in line with the rest of the PR; please confirmp-diff-syncstill compiles and runs under Deno with the refreshed lockfile.bootstrap-languages/centralized-agent-language/adapter.ts (1)
1-1: Centralized agent adapter import update looks goodThe Ad4m type-only import now points at
https://esm.sh/v135/@perspect3vism/ad4m@0.5.0, consistent with the PR-wide change and with no impact on runtime behavior. Please verify that centralized-agent-language still type-checks and runs correctly with the updated CDN/lockfile.tests/js/languages/test-language/index.ts (1)
1-1: Test language now using v135 Ad4m typesThe type import for
@coasys/ad4m@0.5.0now points to the v135esm.shpath, aligned with the rest of the changes. Please confirm the JS test suite (notablytests/js/languages/test-language) still runs cleanly with the new URL and updated lockfiles.bootstrap-languages/perspective-language/index.ts (1)
1-1: Perspective-language index import aligns with v135 switchThe Ad4m type import now uses the v135
esm.shendpoint, consistent withadapter.tsand other bootstrap languages. Please just verify thatperspective-languagestill compiles and runs as expected after regenerating its Deno lockfile.bootstrap-languages/eas/adapter.ts (1)
1-1: EAS adapter Ad4m type import updated correctlyThe import now targets
https://esm.sh/v135/@perspect3vism/ad4m@0.5.0and should be equivalent from a type/runtime perspective. Please confirm the EAS adapter passes type-checking and any relevant integration tests with the refreshed lockfile.bootstrap-languages/direct-message-language/adapter.ts (1)
1-1: Direct-message adapter runtime import moved to v135The
@perspect3vism/ad4m@0.5.0import now comes from the v135esm.shURL, consistent with the wider migration in this PR. Since this is a value import used at runtime, please double-check that Deno can fetch and cache this URL correctly (e.g., running the DM language tests or a local smoke test).bootstrap-languages/file-storage/adapter.ts (1)
1-3: Pinned esm.sh/v135 imports for ad4m types and pako look consistentThe move to
https://esm.sh/v135/@perspect3vism/ad4m@0.5.0andhttps://esm.sh/v135/pako@2.1.0aligns with the PR’s lockfile strategy and should be a no-op behaviorally.Please run your usual Deno test/check workflow to confirm esm.sh’s v135 default exports (
pakoin particular) still match the expected shape.bootstrap-languages/centralized-agent-language/index.ts (1)
1-1: Ad4m type import retargeted to esm.sh/v135 with no functional impactSwitch to
https://esm.sh/v135/@perspect3vism/ad4m@0.5.0for the type-only import is consistent with the rest of the PR and should not change behavior.Just ensure the corresponding Deno lockfile has this v135 URL captured and that
deno cache/ tests succeed.bootstrap-languages/direct-message-language/index.ts (1)
1-1: Direct-message language ad4m types now pinned to esm.sh/v135The updated type import is aligned with other bootstrap languages and doesn’t alter the language’s runtime surface.
Please verify that any Deno type-check or compile step referencing this file succeeds with the new v135 endpoint.
bootstrap-languages/language-language/index.ts (1)
1-1: Language-language ad4m types correctly moved to esm.sh/v135Type-only import now uses the versioned v135 URL; behavior of the language module is unchanged.
Confirm that the lockfile and Deno tooling resolve this v135 URL without additional integrity/hash issues.
bootstrap-languages/neighbourhood-language/index.ts (1)
1-1: Neighbourhood-language ad4m type imports updated to v135 consistentlyThe consolidated type import (including
ExpressionUI) fromhttps://esm.sh/v135/@perspect3vism/ad4m@0.5.0looks correct and keeps runtime behavior the same.Please run whatever neighbourhood-language tests you have to double-check that esm.sh’s v135 build still exposes these types as expected.
bootstrap-languages/agent-language/index.ts (1)
1-1: Agent-language ad4m type import pinned to esm.sh/v135The updated type import for
Address,Language,LanguageContext,HolochainLanguageDelegate, andInteractionaligns with the rest of the PR and should not affect the agent language’s behavior.Please ensure your Deno build that registers DNAs for this language still succeeds with the v135 endpoint in place.
tests/js/scripts/get-builtin-test-langs.js (1)
1-3: Test helper now pins fs-extra, node-wget-js, unzipper to esm.sh/v135Using
fs-extra@11.1.1,node-wget-js@1.0.1, andunzipper@0.10.14via v135 is consistent with the PR’s lockfile/esm.sh strategy; the download/unzip logic remains unchanged.Please run the test-language bootstrap script (or the CI job that calls it) once with a clean cache to verify these v135-backed imports behave identically.
bootstrap-languages/file-storage/index.ts (1)
1-1: LGTM: Consistent versioned import path update.The import path has been correctly updated to use the v135 versioned URL, consistent with the other files in this PR.
bootstrap-languages/language-language/putAdapter.ts (1)
1-1: LGTM: Consistent versioned import path update.The import path has been correctly updated to use the v135 versioned URL.
bootstrap-languages/language-language/languageAdapter.ts (1)
1-1: LGTM: Consistent versioned import path update.The import path has been correctly updated to use the v135 versioned URL.
bootstrap-languages/eas/index.ts (1)
1-1: LGTM: Consistent versioned import path update.The import path has been correctly updated to use the v135 versioned URL.
bootstrap-languages/p-diff-sync/linksAdapter.ts (1)
2-4: LGTM: Multiple import paths updated to versioned v135 URLs.All three import statements have been correctly updated to use v135 versioned URLs for both
@perspect3vism/ad4m@0.5.0andasync-mutex@0.4.0. The changes are consistent with the PR objective.bootstrap-languages/language-language/adapter.ts (1)
1-1: LGTM: Consistent versioned import path update.The import path has been correctly updated to use the v135 versioned URL.
bootstrap-languages/perspective-language/putAdapter.ts (1)
1-1: LGTM: Consistent versioned import path update.The import path has been correctly updated to use the v135 versioned URL, completing the systematic migration across all reviewed files.
bootstrap-languages/centralized-p-diff-sync/index.ts (1)
1-4: I'll help you verify the review comment about the esm.sh versioning changes. Let me start by examining the actual file changes and researching esm.sh v135.
<function_calls>
#!/bin/bashFirst, let's verify the actual file content
echo "=== Checking file content ==="
cat -n "bootstrap-languages/centralized-p-diff-sync/index.ts" | head -10Let's also check if there are other files with esm.sh imports to see v135 usage consistency
echo ""
echo "=== Searching for esm.sh imports across the repository ==="
rg "esm.sh/v" --type ts --type tsx -n | head -20
</function_calls>
<function_calls>
esm.sh CDN versioning v135 what is it used for
</function_calls>bootstrap-languages/centralized-p-diff-sync/linksAdapter.ts (1)
2-5: Import URL pinning to esm.sh v135 is consistent and correctad4m, async-mutex, and socket.io-client imports are all moved to
esm.sh/v135/*without changing library versions or usage. Using a separateimport typeforSyncStateChangeObserverkeeps runtime imports minimal. No issues from this change.bootstrap-languages/centralized-file-storage/index.ts (1)
1-1: Ad4m type import moved to v135 with no behavioral impactThe import now targets
https://esm.sh/v135/@perspect3vism/ad4m@0.5.0, which matches the pattern elsewhere in the PR. Usage ofAddress,Language,LanguageContext,ExpressionUI, andInteractionis unchanged, so behavior remains the same.tests/js/languages/note-store/index.ts (1)
1-1: Test-language ad4m import updated to v135, consistent with main codeThe switch to
https://esm.sh/v135/@coasys/ad4m@0.5.0keeps the same library version while aligning the test language with the v135 CDN path used elsewhere. No functional changes introduced.bootstrap-languages/file-storage/putAdapter.ts (1)
1-5: Pinned ad4m and pako imports to esm.sh v135 without changing behaviorUpdating ad4m and pako to
esm.sh/v135/*(and even the commented Blob import) simply pins the CDN build variant while keeping the same package versions and usage. TheFileStoragePutAdapterbehavior is unaffected.bootstrap-languages/file-storage/types.ts (1)
1-1: ExpressionGeneric import URL updated correctlyImporting
ExpressionGenericfromhttps://esm.sh/v135/@perspect3vism/ad4m@0.5.0keeps the same type factory while aligning with other v135 imports.FileExpression’s definition remains identical in behavior.bootstrap-languages/centralized-file-storage/adapter.ts (1)
1-4: Centralized file-storage adapter imports correctly pinned to v135Both the type imports and
ExpressionGenericnow come fromhttps://esm.sh/v135/@perspect3vism/ad4m@0.5.0, matching the rest of the codebase and avoiding integrity mismatches, with no change to howPutAdapterorAdapterbehave.
2 participants
Deno lockfiles updated to fix hash mismatches and integrity check failures with esm.sh
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Note
Refreshes Deno lockfiles (root and test languages) and updates test build scripts to use --no-lock and --reload.
deno.lockredirects and remotes for esm.sh (e.g.,brace-expansion@1.1.12,jsonfile@6.2.0) and refresh hashes; remove unuseddeno.land/esbuild entries.tests/js/languages/{note-store,test-language}/deno.lockto pin test dependencies.tests/js/languages/{note-store,test-language}/package.json, changebuildtodeno run --allow-all --no-lock --reload esbuild.ts.Written by Cursor Bugbot for commit 9a74a4f. This will update automatically on new commits. Configure here.