ci: Update language test workflows to Node 18.x#656
Conversation
📝 WalkthroughWalkthroughUpdated multiple GitHub Actions workflows to use Node.js 22.x (previously 16.x) in CI matrices and added a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
17ac263 to
54bc1e2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/agent-language-tests.yml:
- Line 20: Update the GitHub Actions runner Node version by changing the
node-version entry from [18.x] to a supported LTS (recommended [22.x]) so the
workflow uses a currently supported Node release; specifically edit the
node-version key in the agent-language-tests workflow and replace its value
(node-version: [18.x]) with node-version: [22.x] (or another supported LTS like
20.x/24.x) to satisfy pnpm >=18.12 and avoid EOL runtimes.
🧹 Nitpick comments (3)
docs/CNAME (1)
1-1: Unrelated to PR scope — consider splitting.This CNAME file for GitHub Pages is unrelated to the CI Node.js version fix described in the PR. Consider separating it into its own commit or PR to keep changes atomic and reviewable.
.github/workflows/agent-language-tests.yml (1)
26-27: Outdated GitHub Actions versions — consider bumping.Several actions in this workflow are significantly outdated:
actions/checkout@v2→ latest isactions/checkout@v6actions/setup-node@v2→ latest isactions/setup-node@v6actions/cache@v3→ v4 is currentactions-rs/toolchain@v1is archived/unmaintainedOlder action versions run on deprecated Node.js runtimes internally and may produce deprecation warnings or break on future runner updates.
Also applies to: 33-33, 44-44
.github/workflows/p-diff-sync-tests.yml (1)
331-374: Consider removing the commented-outintegrationjob.This entire job has been commented out (and also got the 18.x update at Line 337). If it's no longer needed, removing it reduces noise. If it's expected to be re-enabled later, consider tracking it via an issue instead.
pnpm 9.x requires Node.js v18.12 or higher. The language test workflows were using Node 16.x which caused all tests to fail. Updated to Node 22.x (current LTS) as recommended by CodeRabbit. Updated workflows: - agent-language-tests.yml - direct-message-language-tests.yml - file-storage-language-tests.yml - p-diff-sync-tests.yml
54bc1e2 to
fc90cb5
Compare
Summary
Updates the Node.js version in language test workflows from 16.x to 18.x.
Problem
All language test workflows have been failing since ~December 2025 with:
pnpm 9.x dropped support for Node 16.x.
Changes
Updated
node-version: [16.x]→node-version: [18.x]in:.github/workflows/agent-language-tests.yml.github/workflows/direct-message-language-tests.yml.github/workflows/file-storage-language-tests.yml.github/workflows/p-diff-sync-tests.ymlTesting
This should restore language test coverage that has been missing for 2+ months.
Summary by CodeRabbit
Chores
Documentation