Skip to content

ci: Update language test workflows to Node 18.x#656

Merged
lucksus merged 2 commits intodevfrom
fix/language-tests-node-18
Feb 6, 2026
Merged

ci: Update language test workflows to Node 18.x#656
lucksus merged 2 commits intodevfrom
fix/language-tests-node-18

Conversation

@data-coasys
Copy link
Contributor

@data-coasys data-coasys commented Feb 6, 2026

Summary

Updates the Node.js version in language test workflows from 16.x to 18.x.

Problem

All language test workflows have been failing since ~December 2025 with:

ERROR: This version of pnpm requires at least Node.js v18.12

pnpm 9.x dropped support for Node 16.x.

Changes

Updated node-version: [16.x]node-version: [18.x] in:

  • .github/workflows/agent-language-tests.yml
  • .github/workflows/direct-message-language-tests.yml
  • .github/workflows/file-storage-language-tests.yml
  • .github/workflows/p-diff-sync-tests.yml

Testing

This should restore language test coverage that has been missing for 2+ months.

Summary by CodeRabbit

  • Chores

    • Upgraded Node.js runtime in continuous integration workflows from 16.x to 22.x to align CI with newer runtime and improve build compatibility.
  • Documentation

    • Added a documentation domain alias to simplify access to the project docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

Updated multiple GitHub Actions workflows to use Node.js 22.x (previously 16.x) in CI matrices and added a docs/CNAME file with the documentation domain docs.ad4m.dev. No runtime logic, API, or workflow control-flow changes.

Changes

Cohort / File(s) Summary
GitHub Actions — agent tests
.github/workflows/agent-language-tests.yml
Node.js matrix entry changed from 16.x to 22.x. No other workflow changes.
GitHub Actions — direct message tests
.github/workflows/direct-message-language-tests.yml
Node.js matrix entry changed from 16.x to 22.x. No other workflow changes.
GitHub Actions — file storage tests
.github/workflows/file-storage-language-tests.yml
Node.js matrix entries changed from 16.x to 22.x for affected jobs. No other workflow changes.
GitHub Actions — p-diff sync tests
.github/workflows/p-diff-sync-tests.yml
Node.js matrix entries changed from 16.x to 22.x across multiple jobs (unit, pull, render, revisions, signals, stress, telepresence). No other workflow changes.
Documentation
docs/CNAME
New file added containing docs.ad4m.dev as the documentation domain alias.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

"I hopped through YAML and curls of code,
Pushed Node up the hill — a lighter load,
A tiny CNAME plants a flag so neat,
Docs dancing on docs.ad4m.dev — what a treat! 🐇"

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'Node 18.x' but the actual changes update workflows to Node 22.x, creating a significant mismatch between the title and the implementation. Update the PR title to accurately reflect the Node.js version being updated to, e.g., 'ci: Update language test workflows to Node 22.x'
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/language-tests-node-18

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

lucksus
lucksus previously approved these changes Feb 6, 2026
@data-coasys data-coasys changed the base branch from main to dev February 6, 2026 16:30
@data-coasys data-coasys dismissed lucksus’s stale review February 6, 2026 16:30

The base branch was changed.

@data-coasys data-coasys force-pushed the fix/language-tests-node-18 branch from 17ac263 to 54bc1e2 Compare February 6, 2026 16:30
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/agent-language-tests.yml:
- Line 20: Update the GitHub Actions runner Node version by changing the
node-version entry from [18.x] to a supported LTS (recommended [22.x]) so the
workflow uses a currently supported Node release; specifically edit the
node-version key in the agent-language-tests workflow and replace its value
(node-version: [18.x]) with node-version: [22.x] (or another supported LTS like
20.x/24.x) to satisfy pnpm >=18.12 and avoid EOL runtimes.
🧹 Nitpick comments (3)
docs/CNAME (1)

1-1: Unrelated to PR scope — consider splitting.

This CNAME file for GitHub Pages is unrelated to the CI Node.js version fix described in the PR. Consider separating it into its own commit or PR to keep changes atomic and reviewable.

.github/workflows/agent-language-tests.yml (1)

26-27: Outdated GitHub Actions versions — consider bumping.

Several actions in this workflow are significantly outdated:

  • actions/checkout@v2 → latest is actions/checkout@v6
  • actions/setup-node@v2 → latest is actions/setup-node@v6
  • actions/cache@v3 → v4 is current
  • actions-rs/toolchain@v1 is archived/unmaintained

Older action versions run on deprecated Node.js runtimes internally and may produce deprecation warnings or break on future runner updates.

Also applies to: 33-33, 44-44

.github/workflows/p-diff-sync-tests.yml (1)

331-374: Consider removing the commented-out integration job.

This entire job has been commented out (and also got the 18.x update at Line 337). If it's no longer needed, removing it reduces noise. If it's expected to be re-enabled later, consider tracking it via an issue instead.

pnpm 9.x requires Node.js v18.12 or higher. The language test
workflows were using Node 16.x which caused all tests to fail.

Updated to Node 22.x (current LTS) as recommended by CodeRabbit.

Updated workflows:
- agent-language-tests.yml
- direct-message-language-tests.yml
- file-storage-language-tests.yml
- p-diff-sync-tests.yml
@data-coasys data-coasys force-pushed the fix/language-tests-node-18 branch from 54bc1e2 to fc90cb5 Compare February 6, 2026 16:49
@lucksus lucksus merged commit e76dc7a into dev Feb 6, 2026
1 of 2 checks passed
lucksus added a commit that referenced this pull request Feb 18, 2026
Adds 21 entries (Fixed ×11, Added ×5, Changed ×5) covering PRs #629#680
merged after the 0.11.1 release. CI-only PRs (#656, #657, #659) omitted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants