Skip to content

More skill improvements: auth-flow and NH memory#734

Merged
lucksus merged 3 commits intodevfrom
feature/skill-improvements
Mar 8, 2026
Merged

More skill improvements: auth-flow and NH memory#734
lucksus merged 3 commits intodevfrom
feature/skill-improvements

Conversation

@lucksus
Copy link
Copy Markdown
Member

@lucksus lucksus commented Mar 8, 2026

  • ensure admin-credential works with our MCP server code
  • describe JWT session login as fallback since MCP clients don't always relay auth bearer from config
  • clarify: perspective ID local VS neighbourhood URL global
  • have agents create and keep a memory about neighbourhoods
  • remove neighbourhood URL from waker config, since clients identify perspectives to work with - connect perspectives and neighbourhoods via list_perspectives result

Summary by CodeRabbit

Release Notes

  • Documentation

    • Updated authentication guidance with admin credential and JWT authentication options
    • Clarified perspective UUID management and neighborhood workflow documentation
    • Updated waker configuration examples and guidelines
  • Tests

    • Added comprehensive HTTP Authorization header authentication test suite

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80d17d05-32b0-498d-a3f0-e801eda912da

📥 Commits

Reviewing files that changed from the base of the PR and between fff8df8 and 7eeec50.

📒 Files selected for processing (8)
  • skills/ad4m/SKILL.md
  • skills/ad4m/references/mcp.md
  • skills/ad4m/references/waker.md
  • skills/ad4m/waker/README.md
  • skills/ad4m/waker/ad4m-waker.js
  • skills/ad4m/waker/waker-config.example.json
  • tests/js/tests/mcp-auth.test.ts
  • tests/js/tests/mcp-utils.ts

📝 Walkthrough

Walkthrough

This PR reorganizes authentication documentation to emphasize Bearer token and JWT flows, updates waker and perspective configuration guidance to distinguish local perspective UUIDs from neighborhood URLs, adds HTTP Authorization header authentication tests, and enhances test utilities to support custom headers.

Changes

Cohort / File(s) Summary
Authentication & Perspective Documentation
skills/ad4m/SKILL.md, skills/ad4m/references/mcp.md
Reorganizes authentication guidance to emphasize Bearer token format and JWT flow; adds sections clarifying that perspective UUIDs are local and distinct from neighborhood URLs; introduces rules for storing neighborhood context and installing wakers.
Waker Configuration References
skills/ad4m/references/waker.md, skills/ad4m/waker/README.md, skills/ad4m/waker/ad4m-waker.js
Updates waker documentation to replace generic perspective UUIDs with local perspective UUID references; removes neighborhood field from subscription objects and configuration examples.
Waker Configuration Example
skills/ad4m/waker/waker-config.example.json
Updates perspective references from neighborhood-perspective-uuid to local-perspective-uuid; removes neighborhood field from subscription entries.
Test Infrastructure
tests/js/tests/mcp-auth.test.ts
Adds new test suite for HTTP Authorization header admin-credential authentication paths including bare token, Bearer token, and error cases.
Test Utilities
tests/js/tests/mcp-utils.ts
Adds optional extraHeaders parameter to mcpHttpRequest and callMcpTool functions to support custom HTTP headers in test calls.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

Suggested reviewers

  • marvin-bot-coasys

Poem

🐰 Local UUIDs dance, neighborhoods roam free,
Bearer tokens guide the way with JWT's key,
Wake up to new perspectives, stored with care,
Authentication flows with headers fair! 🔐

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/skill-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lucksus lucksus merged commit 6bfe46c into dev Mar 8, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant