Fixes issue #106 - coc-powershell fails to open automatically for ps1…#108
Merged
TylerLeonhardt merged 2 commits intococ-extensions:masterfrom Aug 31, 2020
lc9er:master
Merged
Fixes issue #106 - coc-powershell fails to open automatically for ps1…#108TylerLeonhardt merged 2 commits intococ-extensions:masterfrom lc9er:master
TylerLeonhardt merged 2 commits intococ-extensions:masterfrom
lc9er:master
Conversation
corbob
requested changes
Aug 30, 2020
Member
There was a problem hiding this comment.
Could we ensure we include common capitalizations of PowerShell? The Syntax Highlighting in vim-polyglot seems to be case insensitive, but activation of the coc.nvim extension seems to be case sensitive ¯\_(ツ)_/¯
This is probably a little bit more than is needed, but it seems better to be prepared for users setting filetype "improperly" than to field issues that crop up when they do.
Co-authored-by: corbob <30301021+corbob@users.noreply.github.com>
Contributor
Author
|
Ok @corbob - I commited the changes you provided. Is there anything else I need to do? |
corbob
approved these changes
Aug 31, 2020
Collaborator
|
This is in 0.13 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… filetypes.
Addresses Issue #106, where coc-powershell fails to start when a ps1 file is opened.