Skip to content

Allow ability to change powershell version#16

Merged
yatli merged 3 commits intococ-extensions:masterfrom
TylerLeonhardt:switch-powershell-exe-2
May 20, 2019
Merged

Allow ability to change powershell version#16
yatli merged 3 commits intococ-extensions:masterfrom
TylerLeonhardt:switch-powershell-exe-2

Conversation

@TylerLeonhardt
Copy link
Copy Markdown
Collaborator

@TylerLeonhardt TylerLeonhardt commented May 18, 2019

This way, you can easily switch between Windows PowerShell, PowerShell Core, and PowerShell Core Preview.

This reimplements #14 a bit differently, but in a more coc way.

fixes #13

@TylerLeonhardt TylerLeonhardt requested review from corbob and yatli May 18, 2019 15:45
Copy link
Copy Markdown
Member

@yatli yatli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good overall.

endif
let index = index + 1
endwhile
let s:choice = powershellExecutables[confirm("Which PowerShell executable would you like to use?", choiceStr) - 1].executablePath
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

help confirm(): If the user aborts the dialog by pressing , CTRL-C, or another valid interrupt key, confirm() returns 0.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - now it silently returns if you cancel the prompt.

@yatli
Copy link
Copy Markdown
Member

yatli commented May 20, 2019

All green.

@yatli yatli merged commit ebd96c9 into coc-extensions:master May 20, 2019
@TylerLeonhardt TylerLeonhardt deleted the switch-powershell-exe-2 branch May 20, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose a function to set the powershellExecutable used

2 participants