Resolve type aliases in docblocks#24
Conversation
55294f4 to
c25eeae
Compare
|
@williamdes the aliases from the context don't seem to be used elsewhere, so the later changes should work fine, and not break anyone's builds. I also added unit tests to prevent regression. I consider this PR finished and ready to be merged. If you find anything let me know. |
williamdes
left a comment
There was a problem hiding this comment.
This looks good, I will have another time a look onto your work
c25eeae to
92e1d12
Compare
|
Closing to try to trigger the CIs |
e097f6f to
050c039
Compare
|
As far as I know should be enough, there is no need to match the name of my branch. |
is that to specify the PR target ? |
|
Yup. |
050c039 to
b12d910
Compare
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
============================================
+ Coverage 55.19% 55.43% +0.23%
Complexity 1017 1017
============================================
Files 50 50
Lines 2607 2612 +5
============================================
+ Hits 1439 1448 +9
+ Misses 1168 1164 -4
Continue to review full report at Codecov.
|
Awesome, thank you so much ! All tests pass except php 7.1 Would you too agree to drop support for PHP 7.1 ? |
|
It is fine by me. Not sure why this would fail though. |
It fails because they have a version that is PHP <= 7.1 compatible and one that is compatible PHP > 7.1 |
b12d910 to
53135a9
Compare
53135a9 to
1724f16
Compare
|
I released 5.4.0-dev phar, you can try it out and let me know ;) |
|
Seems to work great, thanks. |
Issue: #23