fix(no-hephaestus-non-gpt): add opt-out for model enforcement#2107
Merged
code-yeongyu merged 4 commits intodevfrom Feb 25, 2026
Merged
fix(no-hephaestus-non-gpt): add opt-out for model enforcement#2107code-yeongyu merged 4 commits intodevfrom
code-yeongyu merged 4 commits intodevfrom
Conversation
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Additive change with a new optional configuration flag. Logic defaults to existing behavior when the flag is unset. Verified by new tests and zero detected issues by cubic.
…vider Hephaestus requires GPT models, which can be provided by github-copilot. The requiresProvider list was missing github-copilot, causing hephaestus to not be created when github-copilot was the only GPT provider connected. This also fixes a flaky CI test that documented this expected behavior.
…uiresProvider" This reverts commit 7e58729.
…st expectation The test 'hephaestus is created when github-copilot provider is connected' had incorrect expectation. github-copilot does not provide gpt-5.3-codex, so hephaestus should NOT be created when only github-copilot is connected. This test was causing CI flakiness due to incorrect assertion and missing readConnectedProvidersCache mock (state pollution between tests). Also adds cacheSpy mock for proper isolation.
There was a problem hiding this comment.
2 issues found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/shared/model-requirements.ts">
<violation number="1">
P1: This line removes `github-copilot` from `requiresProvider`, which contradicts the PR description stating it should be added.</violation>
<violation number="2">
P1: This line removes `github-copilot` from the providers list, which contradicts the PR description stating it should be added.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agents.hephaestus.allow_non_gpt_modelschema support (default behavior unchanged when unset/false).no-hephaestus-non-gpthook to honor this option: still show toast, but only force-switch to Sisyphus when opt-out is disabled.Testing
bun test src/hooks/no-hephaestus-non-gpt/bun run typecheckFixes #2054
Summary by cubic
Adds an opt‑out so Hephaestus can run with non‑GPT models without forcing a switch, and updates provider gating so Hephaestus is not created when only GitHub Copilot is connected. Fixes #2054.
New Features
Bug Fixes
Written for commit 9f64e2a. Summary will update on new commits.