fix(agents): retain original agent keys in remapAgentKeysToDisplayNames to prevent crash#2142
Merged
code-yeongyu merged 1 commit intodevfrom Feb 26, 2026
Merged
Conversation
…es to prevent crash Closes #1922
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The change is purely additive, ensuring original keys remain accessible alongside display names. Tests confirm correct behavior and no regressions in existing lookups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
remapAgentKeysToDisplayNamesdrops original agent keys, causing crashes when agents are accessed by original keys.Root Cause
The function replaces original keys with display names but doesn't retain the original key mappings.
Fix
Keep both original key and display name key in the agents map.
Validation
bun test src/shared/ --timeout 30000bun run typecheckbun run buildCloses #1922
Summary by cubic
Retain original agent keys when remapping to display names to prevent crashes when agents are accessed by their original keys. Resolves Linear #1922.
Written for commit df02c73. Summary will update on new commits.