Skip to content

Conversation

@vmladenovic
Copy link

…l extension marketplace

Fixes #7595

@vmladenovic vmladenovic requested a review from a team as a code owner December 10, 2025 11:43
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice I like this! I think there might be some types that also need to be updated, but CI should tell us more once it runs.

I wonder if we can be more descriptive than token. Maybe authorizationHeaderToken? Or...hmm should we make it a general headers property maybe?? Then users could add whatever headers they need.



Index: code-server/lib/vscode/src/vs/platform/product/common/product.ts
Index: coder-code-server-fork/lib/vscode/src/vs/platform/product/common/product.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we revert all these path changes that rename code-server to coder-code-server-fork?

@vmladenovic
Copy link
Author

vmladenovic commented Dec 11, 2025

Nice I like this! I think there might be some types that also need to be updated, but CI should tell us more once it runs.

I wonder if we can be more descriptive than token. Maybe authorizationHeaderToken? Or...hmm should we make it a general headers property maybe?? Then users could add whatever headers they need.

I guess we could be more descriptive and use authorizationHeaderToken. My idea was to keep it really simple so I wouldn't go with the general "header" property for now if it's OK with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Authorization header to be set when working with a custom extension marketplace

2 participants