feat(ci): build Docker Image on PRs#382
Merged
filipchristiansen merged 3 commits intomainfrom Jul 5, 2025
Merged
Conversation
NicolasIRAGNE
force-pushed
the
feat/docker-ci
branch
2 times, most recently
from
6b81e1e to
f8f9968
Compare
NicolasIRAGNE
force-pushed
the
feat/docker-ci
branch
from
f8f9968 to
c2d9c30
Compare
NicolasIRAGNE
requested review from
Copilot and
filipchristiansen
and removed request for
filipchristiansen
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow to build the Docker image on pull requests and updates the CLI entry point import to use __main__.py.
- Redirect CLI entry point from
gitingest.clitogitingest.__main__ - Update
pyproject.tomlscripts to call the new module path - Introduce
.github/workflows/docker_image.ymlto build Docker images on PRs
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_cli.py | Updated import and test assertion to reference __main__.py |
| pyproject.toml | Changed gitingest script entry to gitingest.__main__:main |
| .github/workflows/docker_image.yml | Added CI workflow to build Docker image on pull requests |
Comments suppressed due to low confidence (1)
.github/workflows/docker_image.yml:25
- Using only the commit SHA as a Docker tag may obscure the image registry or repository. It’s clearer to include the registry/repo prefix (e.g.,
ghcr.io/<owner>/gitingest:${{ github.sha }}) so tags are unambiguous.
tags: "${{ github.sha }}"
2b7922d to
c2d9c30
Compare
filipchristiansen
suggested changes
Jul 5, 2025
Contributor
filipchristiansen
left a comment
filipchristiansen
left a comment
There was a problem hiding this comment.
Just this minor cosmetic adjustment, but otherwise it looks good to me.
Co-authored-by: Filip Christiansen <22807962+filipchristiansen@users.noreply.github.com>
ix-56h
pushed a commit
to ix-56h/gitingest
that referenced
this pull request
Jul 7, 2025
* feat(ci): add GitHub Actions workflows for Docker image build and rename PyPI publish * chore: rename cli module to __main__ so it can be executed without having to build * Update .github/workflows/docker_image.yml Co-authored-by: Filip Christiansen <22807962+filipchristiansen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #370
First step to try and deploy in a cleaner way