coderplus/copy-rename-maven-plugin#10 : Added the ability to skip#14
Open
garethfiler wants to merge 2 commits intocoderplus:masterfrom
Open
coderplus/copy-rename-maven-plugin#10 : Added the ability to skip#14garethfiler wants to merge 2 commits intocoderplus:masterfrom
garethfiler wants to merge 2 commits intocoderplus:masterfrom
Conversation
edwardmlyte
reviewed
Apr 29, 2019
Author
|
@aneesh-joseph any issues with merging this PR? |
wappers
reviewed
Jul 11, 2019
| File destFile = fileSet.getDestinationFile(); | ||
| if(srcFile!=null){ | ||
| copy(srcFile,destFile); | ||
| if(Boolean.FALSE.equals(skip)) { |
There was a problem hiding this comment.
since the skip field is a primitive, use if (skip){log} else{dostuff}
kohlschuetter
added a commit
to kohlschutter/copy-rename-maven-plugin
that referenced
this pull request
Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something that has been raised already in issue #10 and would be useful for us to be able to skip plugin execution.
I have set the default to false to aid backward compatibility with existing users of the plugin.