fix: cli tool does not bundle template, but must read them #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
The
pipx run create-onchain-templatefails because theTEMPLATE_DIRthe CLI was reading from is not bundled with the cli.Temp fix is to read from github main directly. Fast follow with either:
Why was this change implemented?
CLI is not building, EthDenver starts today.
Checklist
How has it been tested?
Manually tested via deleting the local template directory to ensure it isn't reading that, and then running:
Notes to reviewers
I want to discuss a better way to do this in a fast-follow. There is two flaws with this approach.