Skip to content

Conversation

@CarsonRoscoe
Copy link
Contributor

What changed?

  • Bug fix

The pipx run create-onchain-template fails because the TEMPLATE_DIR the CLI was reading from is not bundled with the cli.

Temp fix is to read from github main directly. Fast follow with either:

  1. Sticking to Github, start tagging releases better, and whenever we bump the CLI, we update the github tag we pull from to the one we're about to release.
  2. Find a way to include the template in the cli build directly

Why was this change implemented?

CLI is not building, EthDenver starts today.

Checklist

  • Changelog updated
  • Commits are signed. See instructions
  • Doc strings
  • Readme updates
  • Rebased against main
  • Relevant exports added

How has it been tested?

  • Agent tested
  • Unit tests

Manually tested via deleting the local template directory to ensure it isn't reading that, and then running:

poetry install
poetry build
poetry run create-onchain-agent

Notes to reviewers

I want to discuss a better way to do this in a fast-follow. There is two flaws with this approach.

  1. The CLI slows down slightly, since we're adding a download->extract->move folder to cache step during the CLI. It's faster than I expected, but still a consideration as the project/repo get bigger.
  2. We risk the version of the CLI and the Template getting out of sync, if people are running a older CLI version and pulling newer templates.

@cb-heimdall
Copy link

cb-heimdall commented Feb 24, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 24, 2025
@CarsonRoscoe CarsonRoscoe marked this pull request as ready for review February 24, 2025 16:27
@CarsonRoscoe CarsonRoscoe added the bug Something isn't working label Feb 24, 2025
@CarsonRoscoe CarsonRoscoe merged commit 56a1b97 into main Feb 24, 2025
14 checks passed
@CarsonRoscoe CarsonRoscoe deleted the fix/py-create-onchain-agent-template-reading branch February 24, 2025 17:03
kylexqian pushed a commit to OpenGradient/agentkit that referenced this pull request Feb 25, 2025
)

* fix: cli tool does not bundle template, and must read them from somewhere. temp fix is github

* chore: created/updated changelog

* bump: python create-onchain-agent to 0.1.1

* fix: rename variable for python code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation python

Development

Successfully merging this pull request may close these issues.

3 participants