Skip to content

Conversation

@ya7ya
Copy link
Contributor

@ya7ya ya7ya commented Jul 23, 2025

Description

This adds a new action (unwrap) to the WETH agent actions

Tests

example prompt

user: hey, could you unwrap any WETH I have in the smartWallet? 

https://base-sepolia.blockscout.com/op/0x4a0287b4310eaf1363e6365d5e1b311de6912a8a3f30baf3e35ddb8fc2989e54?tab=logs

Checklist

A couple of things to include in your PR for completeness:

  • Added documentation to all relevant README.md files
  • Added a changelog entry

@ya7ya ya7ya requested a review from murrlincoln as a code owner July 23, 2025 09:43
@cb-heimdall
Copy link

cb-heimdall commented Jul 23, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added documentation Improvements or additions to documentation action provider New action provider typescript labels Jul 23, 2025
@phdargen
Copy link
Contributor

Hi @ya7ya, thanks for your contribution!

## Actions

- `wrap_eth`: Convert ETH to WETH
- `unwrap-eth`: Convert WETH to ETH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be unwrap_eth

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- The amount is a string and cannot have any decimal points, since the unit of measurement is wei.
- Make sure to use the exact amount provided, and if there's any doubt, check by getting more information before continuing with the action.
- 1 wei = 0.000000000000000001 WETH
- Minimum unwrap amount is 100000000000000 wei (0.0000001 WETH)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong, should be 100000000000 wei (0.0000001 WETH)

please also fix for wrap action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@ya7ya ya7ya requested a review from phdargen July 24, 2025 06:45
@phdargen
Copy link
Contributor

Looks good and I tested it successfully @CarsonRoscoe

Copy link
Contributor

@CarsonRoscoe CarsonRoscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good! Thank you for the contribution

@CarsonRoscoe CarsonRoscoe merged commit 73ea2e0 into coinbase:main Jul 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action provider New action provider documentation Improvements or additions to documentation typescript

Development

Successfully merging this pull request may close these issues.

4 participants