-
Notifications
You must be signed in to change notification settings - Fork 604
unwrap weth action #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unwrap weth action #796
Conversation
✅ Heimdall Review Status
|
|
Hi @ya7ya, thanks for your contribution!
|
| ## Actions | ||
|
|
||
| - `wrap_eth`: Convert ETH to WETH | ||
| - `unwrap-eth`: Convert WETH to ETH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should be unwrap_eth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| - The amount is a string and cannot have any decimal points, since the unit of measurement is wei. | ||
| - Make sure to use the exact amount provided, and if there's any doubt, check by getting more information before continuing with the action. | ||
| - 1 wei = 0.000000000000000001 WETH | ||
| - Minimum unwrap amount is 100000000000000 wei (0.0000001 WETH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is wrong, should be 100000000000 wei (0.0000001 WETH)
please also fix for wrap action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
Looks good and I tested it successfully @CarsonRoscoe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, looks good! Thank you for the contribution
Description
This adds a new action (unwrap) to the WETH agent actions
Tests
example prompt
Checklist
A couple of things to include in your PR for completeness: