[spaces/rec2020] Use gamma 2.40 for display-referred rec2020 #669#672
[spaces/rec2020] Use gamma 2.40 for display-referred rec2020 #669#672
Conversation
…previous implementation as scene-referred --rec2020-oetf #669
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Build gives a bunch of type linting errors completely unrelated to the files I changed. |
facelessuser
left a comment
There was a problem hiding this comment.
As far as implementation, everything looks fine. But related Rec. 2020 tests would need to be updated as some are failing:
- Rec. 2020 <-> Linear Rec. 2020
- APCA contrast, sRGB gamut in other color spaces
|
As a side note, I don't know when it happened, but it seems gamut mapping tests are not working: https://colorjs.io/test/ I'm thinking there may be some infinite recursion or something as it seems we blow the call stack: |
|
I don't see anything obviously wrong with gamut mapping or stringifying the output, so I suspect gamut mapping tests (and a few others) are broken due to calling some special htest check functions. This isn't an area I'm familiar with, but I guess we should open a separate issue to figure out what's going wrong there. |
Agreed, I will fix those |
|
One reason so few |
|
LGTM |
rename previous implementation as scene-referred --rec2020-oetf so people can still use the older implementation if they want
See