[OPIK-5336] [BE] feat: add delete configuration parameters endpoint#5986
Merged
BorisTkachenko merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
thiagohora
reviewed
Mar 31, 2026
Contributor
Backend Tests - Integration Group 15 27 files +7 27 suites +7 3m 22s ⏱️ - 2m 37s For more details on these errors, see this check. Results for commit 638a50b. ± Comparison against base commit d4d8ff0. This pull request removes 186 and adds 188 tests. Note that renamed tests count towards both. |
thiagohora
approved these changes
Mar 31, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds a new
POST /v1/private/agent-configs/blueprints/delete-keysendpoint that "deletes" configuration parameters by creating a new blueprint and closing the specified keys (settingvalid_to_blueprint_id).Changes:
AgentConfigDeleteValuesDTO withprojectId/projectNameand aSet<String> keysHasProjectIdentifierinterface implemented by bothAgentConfigCreateandAgentConfigDeleteValues, allowing theProjectIdentifierValidatorto validate both typesdeleteConfigValuesmethod toAgentConfigService— validates config exists, closes specified keys, creates a new blueprint with description "Deleted configuration parameters: [keys]"resolveProjectIdto acceptHasProjectIdentifierinstead ofAgentConfigCreateChange checklist
Issues
Testing
deleteConfigValues: Creates config with 3 keys, deletes 2, verifies only 1 remains in latest blueprintdeleteConfigValues__whenAllKeysDeleted: Deletes all keys, verifies empty values and descriptiondeleteConfigValues__whenNoConfig__thenReturn404: Verifies 404 when no config existsDocumentation
N/A