Skip to content

[OPIK-5244] [FE] fix: remove v2 import from plugin GetStartedPage to enforce v1/v2 isolation#5996

Merged
andriidudar merged 3 commits intomainfrom
andriidudar/OPIK-5244-split-plugin-getstartedpage
Mar 31, 2026
Merged

[OPIK-5244] [FE] fix: remove v2 import from plugin GetStartedPage to enforce v1/v2 isolation#5996
andriidudar merged 3 commits intomainfrom
andriidudar/OPIK-5244-split-plugin-getstartedpage

Conversation

@andriidudar
Copy link
Copy Markdown
Contributor

@andriidudar andriidudar commented Mar 31, 2026

Details

Two changes to enforce v1/v2 plugin isolation and add the Invite button to the v2 onboarding flow:

  1. Plugin GetStartedPage v1/v2 isolation: The plugin GetStartedPage.tsx was importing from both @/v1/ and @/v2/, creating a transitive bridge that bypassed dep-cruiser v1/v2 isolation rules. Since the plugin only adds Comet enterprise logic (shouldSkipQuestions) relevant to v1, the v2 import and version branching are removed. The v2 GetStartedPage wrapper (no-op passthrough) is deleted and the router imports NewQuickstart directly.

  2. Add InviteDevButton to v2 AgentOnboarding: The "Need some help?" footer in ConnectAgentStep (manual integration detail view) was missing the "Invite a developer" button that the Figma design shows. Added the InviteDevButton from PluginsStore (same pattern as HelpLinks.InviteDev in v1). Also added an optional size prop to InviteDevButton so it can match the 2xs size of the other footer buttons.

  • Removed @/v2/ import from plugin GetStartedPage.tsx
  • Deleted redundant v2/pages/GetStartedPage/GetStartedPage.tsx wrapper
  • Updated v2 router to import NewQuickstart directly
  • Added InviteDevButton to ConnectAgentStep footer via PluginsStore
  • Added optional size prop to InviteDevButton plugin component

Change checklist

  • User facing
  • Documentation update

Issues

  • OPIK-5244

AI-WATERMARK

AI-WATERMARK: yes

  • Tools: Claude Code
  • Model(s): Claude Opus 4.6
  • Scope: assisted (analysis + implementation)
  • Human verification: code review + lint/typecheck/dep-cruiser validation + visual check

Testing

  • scripts/dev-runner.sh --lint-fe — lint:fix, typecheck, deps:validate all pass
  • Verified no dep-cruiser violations (2095 modules, 12256 dependencies)
  • Confirmed no remaining cross-version imports from plugins via grep
  • Visual verification: InviteDevButton renders in onboarding footer with correct 2xs size

Documentation

N/A

🤖 Generated with Claude Code

…enforce v1/v2 isolation

The plugin GetStartedPage was importing from both v1 and v2, creating a
transitive bridge that bypassed dep-cruiser v1/v2 isolation rules. Since
the plugin only adds Comet enterprise logic relevant to v1, the v2 import
and version branching are removed. The v2 GetStartedPage wrapper (which
was a no-op passthrough) is deleted and the router imports NewQuickstart
directly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@andriidudar andriidudar marked this pull request as ready for review March 31, 2026 11:36
@andriidudar andriidudar requested a review from a team as a code owner March 31, 2026 11:36
@andriidudar andriidudar added the test-environment Deploy Opik adhoc environment label Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.10.57-4753 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch andriidudar/OPIK-5244-split-plugin-getstartedpage
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

@CometActions
Copy link
Copy Markdown
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

Copy link
Copy Markdown
Contributor

@JetoPistola JetoPistola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this ticket @andriidudar 🔥 🎯 1️⃣ 2️⃣

@andriidudar andriidudar merged commit 599f5bf into main Mar 31, 2026
11 checks passed
@andriidudar andriidudar deleted the andriidudar/OPIK-5244-split-plugin-getstartedpage branch March 31, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend test-environment Deploy Opik adhoc environment typescript *.ts *.tsx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants