[OPIK-5244] [FE] fix: remove v2 import from plugin GetStartedPage to enforce v1/v2 isolation#5996
Conversation
…enforce v1/v2 isolation The plugin GetStartedPage was importing from both v1 and v2, creating a transitive bridge that bypassed dep-cruiser v1/v2 isolation rules. Since the plugin only adds Comet enterprise logic relevant to v1, the v2 import and version branching are removed. The v2 GetStartedPage wrapper (which was a no-op passthrough) is deleted and the router imports NewQuickstart directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🔄 Test environment deployment process has started Phase 1: Deploying base version You can monitor the progress here. |
|
✅ Test environment is now available! To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml) Access Information
The deployment has completed successfully and the version has been verified. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JetoPistola
left a comment
There was a problem hiding this comment.
Thanks for picking this ticket @andriidudar 🔥 🎯 1️⃣ 2️⃣
Details
Two changes to enforce v1/v2 plugin isolation and add the Invite button to the v2 onboarding flow:
Plugin GetStartedPage v1/v2 isolation: The plugin
GetStartedPage.tsxwas importing from both@/v1/and@/v2/, creating a transitive bridge that bypassed dep-cruiser v1/v2 isolation rules. Since the plugin only adds Comet enterprise logic (shouldSkipQuestions) relevant to v1, the v2 import and version branching are removed. The v2GetStartedPagewrapper (no-op passthrough) is deleted and the router importsNewQuickstartdirectly.Add InviteDevButton to v2 AgentOnboarding: The "Need some help?" footer in
ConnectAgentStep(manual integration detail view) was missing the "Invite a developer" button that the Figma design shows. Added theInviteDevButtonfrom PluginsStore (same pattern asHelpLinks.InviteDevin v1). Also added an optionalsizeprop toInviteDevButtonso it can match the2xssize of the other footer buttons.@/v2/import from pluginGetStartedPage.tsxv2/pages/GetStartedPage/GetStartedPage.tsxwrapperNewQuickstartdirectlyInviteDevButtontoConnectAgentStepfooter via PluginsStoresizeprop toInviteDevButtonplugin componentChange checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
Testing
scripts/dev-runner.sh --lint-fe— lint:fix, typecheck, deps:validate all pass2xssizeDocumentation
N/A
🤖 Generated with Claude Code