Skip to content

[OPIK-5379] [FE] fix: disable spans link for non-SDK traces#5998

Merged
andriidudar merged 2 commits intomainfrom
andriidudar/OPIK-5379-disable-spans-link-non-sdk
Mar 31, 2026
Merged

[OPIK-5379] [FE] fix: disable spans link for non-SDK traces#5998
andriidudar merged 2 commits intomainfrom
andriidudar/OPIK-5379-disable-spans-link-non-sdk

Conversation

@andriidudar
Copy link
Copy Markdown
Contributor

Details

The "N spans" link in the trace tree viewer header navigates to the Logs page spans view. For non-SDK traces (experiment, playground, optimization), those spans are not visible on the source-filtered Logs page, making the link misleading.

Changed expected behaviour: Instead of fixing the navigation destination, the spans count is now rendered as plain text (not a link) for non-SDK traces. SDK traces and legacy traces (no source) keep the clickable link as before.

  • Added source?: LOGS_SOURCE to the Trace TypeScript interface
  • canNavigateToSpans flag in TraceTreeViewer controls link vs plain text rendering

Change checklist

  • User facing
  • Documentation update

Issues

  • OPIK-5379

AI-WATERMARK

AI-WATERMARK: yes

  • Tools: Claude Code
  • Model(s): Claude Opus 4.6
  • Scope: full implementation
  • Human verification: code review + manual testing

Testing

  • npx tsc --noEmit — compiles clean
  • Manual: open trace from experiment → "N spans" is plain text, not clickable
  • Manual: open trace from Logs page (SDK source) → "N spans" is still a clickable link

Documentation

N/A

…tree viewer

The "N spans" link in the trace tree header navigates to the Logs page
spans view. For non-SDK traces (experiment, playground, optimization),
those spans won't be visible on the source-filtered Logs page, so the
link is replaced with plain text.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions bot added the typescript *.ts *.tsx label Mar 31, 2026
@andriidudar andriidudar added the test-environment Deploy Opik adhoc environment label Mar 31, 2026
@andriidudar andriidudar marked this pull request as ready for review March 31, 2026 11:56
@andriidudar andriidudar requested a review from a team as a code owner March 31, 2026 11:56
@github-actions
Copy link
Copy Markdown
Contributor

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.10.57-4753 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch andriidudar/OPIK-5379-disable-spans-link-non-sdk
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

@CometActions
Copy link
Copy Markdown
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@andriidudar andriidudar merged commit 2e18882 into main Mar 31, 2026
10 checks passed
@andriidudar andriidudar deleted the andriidudar/OPIK-5379-disable-spans-link-non-sdk branch March 31, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend test-environment Deploy Opik adhoc environment typescript *.ts *.tsx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants