[OPIK-5379] [FE] fix: disable spans link for non-SDK traces#5998
Merged
andriidudar merged 2 commits intomainfrom Mar 31, 2026
Merged
[OPIK-5379] [FE] fix: disable spans link for non-SDK traces#5998andriidudar merged 2 commits intomainfrom
andriidudar merged 2 commits intomainfrom
Conversation
…tree viewer The "N spans" link in the trace tree header navigates to the Logs page spans view. For non-SDK traces (experiment, playground, optimization), those spans won't be visible on the source-filtered Logs page, so the link is replaced with plain text. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🔄 Test environment deployment process has started Phase 1: Deploying base version You can monitor the progress here. |
Collaborator
|
✅ Test environment is now available! To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml) Access Information
The deployment has completed successfully and the version has been verified. |
...ik-frontend/src/v2/pages-shared/traces/TraceDetailsPanel/TraceTreeViewer/TraceTreeViewer.tsx
Show resolved
Hide resolved
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aadereiko
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
The "N spans" link in the trace tree viewer header navigates to the Logs page spans view. For non-SDK traces (experiment, playground, optimization), those spans are not visible on the source-filtered Logs page, making the link misleading.
Changed expected behaviour: Instead of fixing the navigation destination, the spans count is now rendered as plain text (not a link) for non-SDK traces. SDK traces and legacy traces (no source) keep the clickable link as before.
source?: LOGS_SOURCEto theTraceTypeScript interfacecanNavigateToSpansflag inTraceTreeViewercontrols link vs plain text renderingChange checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
Testing
npx tsc --noEmit— compiles cleanDocumentation
N/A