[NA] [E2E] fix: increase online scoring test timeouts for GitHub-hosted runners#6024
Merged
AndreiCautisanu merged 1 commit intomainfrom Apr 1, 2026
Conversation
…ed runners Online scoring E2E tests were consistently timing out (60s) on GitHub-hosted runners in post-merge CI, while passing on self-hosted runners. The scoring pipeline (rule activation -> trace creation -> LLM API call -> score storage) takes longer on resource-constrained GitHub-hosted runners. - Increase test timeout from 60s to 120s - Increase polling attempts from 15 to 25 - Increase page refresh wait from 2s to 3s Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NatZol
approved these changes
Apr 1, 2026
| // Timeout constants | ||
| const RULE_ACTIVATION_TIMEOUT = 10000; // 10 seconds for rule to fully activate in backend | ||
| const PAGE_REFRESH_TIMEOUT = 2000; // 2 seconds wait after page refresh | ||
| const PAGE_REFRESH_TIMEOUT = 3000; // 3 seconds wait after page refresh |
Contributor
There was a problem hiding this comment.
Should we replace PAGE_REFRESH_TIMEOUT = 3000 and any page.waitForTimeout uses with retry-capable assertions or helper waits per .agents/skills/playwright-e2e/test-conventions.md, and remove the sleep in the moderation scoring retry loop?
Finding type: AI Coding Guidelines | Severity: 🟢 Low
Want Baz to fix this for you? Activate Fixer
Other fix methods
Prompt for AI Agents:
Before applying, verify this suggestion against the current code. In
tests_end_to_end/typescript-tests/tests/online-scoring/online-scoring.spec.ts around
lines 10 to 10, the PAGE_REFRESH_TIMEOUT constant is set to 3000ms which introduces a
hard-coded delay >2s; per test conventions remove or reduce this constant and do not use
it for page.waitForTimeout. Replace any uses of PAGE_REFRESH_TIMEOUT and any
page.waitForTimeout calls (search around lines 120-140 and specifically 129-133) with
retry-capable helpers such as expect(...).toBeVisible({ timeout: 2000 }) or
helperClient.waitUntil/polling helpers. Also in the moderation scoring retry loop around
lines 106 to 113 (and any loop using sleeps), remove the sleep-based waits and implement
polling using expect/assert-with-timeout or a helper that retries until the moderation
column appears or a total timeout is reached, ensuring no single hard-coded pause
exceeds 2s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Online scoring E2E tests were consistently timing out (60s) on GitHub-hosted runners in post-merge CI while passing on self-hosted runners. Investigation via Allure TestOps showed the scoring pipeline (rule activation → LLM API call → score storage) takes longer on resource-constrained
ubuntu-latestrunners compared to self-hostedautomation-q5pjv-*pods.Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
Testing
Verified by analyzing Allure TestOps data:
Documentation
N/A