Skip to content

[OPIK-5553][FE]: fix a bug with experiments;#6032

Merged
aadereiko merged 1 commit intomainfrom
sashaa/OPIK-5553/feedback-score-experiment-reason
Apr 1, 2026
Merged

[OPIK-5553][FE]: fix a bug with experiments;#6032
aadereiko merged 1 commit intomainfrom
sashaa/OPIK-5553/feedback-score-experiment-reason

Conversation

@aadereiko
Copy link
Copy Markdown
Collaborator

Details

FIxed a bug related to feedback score cells;

image

Change checklist

  • User facing
  • Documentation update

Issues

  • Resolves #
  • OPIK-5553

AI-WATERMARK

  • Tools: Claude Code
  • Model(s): Opus

Testing

  • Manually
  • npm run lint
  • npm run typecheck

Documentation

@aadereiko aadereiko requested a review from a team as a code owner April 1, 2026 13:40
Comment on lines +50 to 52
const isCompact =
rowHeight === ROW_HEIGHT.small || rowHeight === ROW_HEIGHT.medium;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isCompact treating ROW_HEIGHT.medium as compact removes the inline line-clamp-3 preview — should we keep ROW_HEIGHT.medium non-compact or otherwise render the inline preview unless OPIK-5553 required hiding it?

Finding type: Logical Bugs | Severity: 🟠 Medium


Want Baz to fix this for you? Activate Fixer

Other fix methods

Fix in Cursor

Prompt for AI Agents:

Before applying, verify this suggestion against the current code. In
apps/opik-frontend/src/v2/pages-shared/experiments/CompareExperimentsFeedbackScoreCell/CompareExperimentsFeedbackScoreCell.tsx
around lines 50 to 52, the isCompact flag now returns true for both ROW_HEIGHT.small and
ROW_HEIGHT.medium which causes medium rows to use the tooltip-only branch. Change
isCompact to only be true for ROW_HEIGHT.small (const isCompact = rowHeight ===
ROW_HEIGHT.small) and restore the non-compact rendering branch for medium rows so they
show the inline, line-clamped reason preview (use rowHeight === ROW_HEIGHT.medium ->
line-clamp-3 and rowHeight === ROW_HEIGHT.large -> line-clamp-[16] as before). Ensure
size props and conditional rendering use the updated isCompact flag so medium rows
render inline text instead of only the tooltip.

@aadereiko aadereiko merged commit 85683b9 into main Apr 1, 2026
10 checks passed
@aadereiko aadereiko deleted the sashaa/OPIK-5553/feedback-score-experiment-reason branch April 1, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants