[OPIK-5553][FE]: fix a bug with experiments;#6032
Merged
Conversation
Comment on lines
+50
to
52
| const isCompact = | ||
| rowHeight === ROW_HEIGHT.small || rowHeight === ROW_HEIGHT.medium; | ||
|
|
Contributor
There was a problem hiding this comment.
isCompact treating ROW_HEIGHT.medium as compact removes the inline line-clamp-3 preview — should we keep ROW_HEIGHT.medium non-compact or otherwise render the inline preview unless OPIK-5553 required hiding it?
Finding type: Logical Bugs | Severity: 🟠 Medium
Want Baz to fix this for you? Activate Fixer
Other fix methods
Prompt for AI Agents:
Before applying, verify this suggestion against the current code. In
apps/opik-frontend/src/v2/pages-shared/experiments/CompareExperimentsFeedbackScoreCell/CompareExperimentsFeedbackScoreCell.tsx
around lines 50 to 52, the isCompact flag now returns true for both ROW_HEIGHT.small and
ROW_HEIGHT.medium which causes medium rows to use the tooltip-only branch. Change
isCompact to only be true for ROW_HEIGHT.small (const isCompact = rowHeight ===
ROW_HEIGHT.small) and restore the non-compact rendering branch for medium rows so they
show the inline, line-clamped reason preview (use rowHeight === ROW_HEIGHT.medium ->
line-clamp-3 and rowHeight === ROW_HEIGHT.large -> line-clamp-[16] as before). Ensure
size props and conditional rendering use the updated isCompact flag so medium rows
render inline text instead of only the tooltip.
awkoy
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
FIxed a bug related to feedback score cells;
Change checklist
Issues
AI-WATERMARK
Testing
npm run lintnpm run typecheckDocumentation