Skip to content

[OPIK-5535] Fix 403 on get_blueprint() when resolving project by name #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldaugusto merged 2 commits into from
Apr 2, 2026
Merged

[OPIK-5535] Fix 403 on get_blueprint() when resolving project by name #6051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d110cd8
[OPIK-5535] Add projects/retrieve to PUBLIC_ENDPOINTS whitelist
ldaugusto Apr 2, 2026
8f77567
[OPIK-5535] Enforce visibility in retrieveByName and add cross-worksp…
ldaugusto Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,7 @@ public Project retrieveByName(@NonNull String projectName) {
});

return projects
.flatMap(project -> verifyVisibility(project, requestContext.get().getVisibility()))
.map(project -> {
Map<UUID, Instant> projectLastUpdatedTraceAtMap = transactionTemplateAsync
.nonTransaction(connection -> {
Expand Down
1 change: 1 addition & 0 deletions apps/opik-backend/src/main/java/com/comet/opik/infrastructure/auth/RemoteAuthService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class RemoteAuthService implements AuthService {
Set.of("GET"));
put("^/v1/private/projects/[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}/metrics/?$",
Set.of("POST"));
put("^/v1/private/projects/retrieve/?$", Set.of("POST"));
Comment thread
ldaugusto marked this conversation as resolved.
put("^/v1/private/spans/?$", Set.of("GET"));
put("^/v1/private/spans/stats/?$", Set.of("GET"));
put("^/v1/private/spans/feedback-scores/names/?$", Set.of("GET"));
Expand Down
33 changes: 33 additions & 0 deletions ...opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/ProjectsResourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,39 @@ Stream<Arguments> getProjectById__whenRetrieveRequestIsInvalid__thenReturnError(
404));
}

@Test
@DisplayName("when retrieving project from another workspace, then return 404")
void retrieveProject__whenProjectBelongsToAnotherWorkspace__thenReturn404() {
// Set up workspace A with a project
String workspaceNameA = UUID.randomUUID().toString();
String apiKeyA = UUID.randomUUID().toString();
String workspaceIdA = UUID.randomUUID().toString();
mockTargetWorkspace(apiKeyA, workspaceNameA, workspaceIdA);

var project = factory.manufacturePojo(Project.class);
createProject(project, apiKeyA, workspaceNameA);

// Set up workspace B with a different API key
String workspaceNameB = UUID.randomUUID().toString();
String apiKeyB = UUID.randomUUID().toString();
String workspaceIdB = UUID.randomUUID().toString();
mockTargetWorkspace(apiKeyB, workspaceNameB, workspaceIdB);

// Try to retrieve workspace A's project using workspace B's credentials
try (var actualResponse = client.target(URL_TEMPLATE.formatted(baseURI))
.path("retrieve")
.request()
.header(HttpHeaders.AUTHORIZATION, apiKeyB)
.header(WORKSPACE_HEADER, workspaceNameB)
.post(Entity.json(ProjectRetrieve.builder().name(project.name()).build()))) {

assertThat(actualResponse.getStatusInfo().getStatusCode()).isEqualTo(404);
assertThat(actualResponse.hasEntity()).isTrue();
assertThat(actualResponse.readEntity(ErrorMessage.class).errors())
.contains("Project not found");
}
}

}

@Nested
Expand Down
Loading