[OPIK-5658] [FE] fix: align KPI metrics logsSource filter with traces table#6072
Merged
thiagohora merged 2 commits intomainfrom Apr 4, 2026
Conversation
apps/opik-frontend/src/v2/pages-shared/traces/MetricsSummary/MetricsSummary.tsx
Show resolved
Hide resolved
…inerChart and ThreadsTab
aadereiko
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
On the Logs page (Traces tab), the metrics header was showing a trace count that didn't match what the table displayed. When a project had traces from non-SDK sources (e.g. playground, online evaluation), the metrics header counted all traces while the table filtered to SDK-only traces — causing the "Log your first trace" empty state to appear even though the header showed N traces.
The fix adds a
logsSourceprop toMetricsSummaryand threads it through touseProjectKpiCards, which now passes it as an additional filter (alongside existing user filters) to the/kpi-cardsendpoint. TheTracesSpansTabpassesLOGS_SOURCE.sdkso the metrics and table share the same filter scope. The prop is optional so other consumers ofMetricsSummaryare unaffected.Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
Testing
FilterStrategy.TRACEsupportsTraceField.SOURCEwithENUM_LEGACYtype (includes legacyunknownrows forsdkfilter)npm run lint— passedreact-h5-audio-playertype error unrelated to this changeDocumentation
N/A — internal filter alignment, no user-facing documentation changes required.