Skip to content

[OPIK-5628] [FE] Clear stale job state on sandbox disconnect#6091

Merged
miguelgrc merged 1 commit intomainfrom
miguelg/OPIK-5628-clear-error-on-reconnect
Apr 7, 2026
Merged

[OPIK-5628] [FE] Clear stale job state on sandbox disconnect#6091
miguelgrc merged 1 commit intomainfrom
miguelg/OPIK-5628-clear-error-on-reconnect

Conversation

@miguelgrc
Copy link
Copy Markdown
Contributor

@miguelgrc miguelgrc commented Apr 6, 2026

Details

When an SDK connection dropped and a new one was established in the Agent Sandbox, results/errors from the previous session were still displayed. This was because activeJobId was never cleared on disconnect. The fix resets it in the existing isConnected effect so each new session starts clean.

Change checklist

  • User facing
  • Documentation update

Issues

  • OPIK-5628

AI-WATERMARK

AI-WATERMARK: yes

  • If yes:
    • Tools: Claude Code
    • Model(s): claude-opus-4-6
    • Scope: Implementation guided by human
    • Human verification: Yes — reviewed approach and code

Testing

  • npx tsc --noEmit — passes
  • npx eslint src/v2/pages/AgentRunnerPage/AgentRunnerContent.tsx — passes
  • Manual scenario: connect SDK → run job that fails → disconnect → reconnect → verify error is gone

Documentation

N/A

When the SDK connection dropped and a new one was established, the
previous session's results/errors were still displayed. Reset
activeJobId on disconnect so each session starts clean.
@miguelgrc miguelgrc requested a review from a team as a code owner April 6, 2026 18:09
@miguelgrc miguelgrc added the test-environment Deploy Opik adhoc environment label Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.10.59-4806 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch miguelg/OPIK-5628-clear-error-on-reconnect
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

@CometActions
Copy link
Copy Markdown
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

@CometActions
Copy link
Copy Markdown
Collaborator

🌙 Nightly cleanup: The test environment for this PR (pr-6091) has been cleaned up to free cluster resources. PVCs are preserved — re-deploy to restore the environment.

@CometActions CometActions removed the test-environment Deploy Opik adhoc environment label Apr 7, 2026
@miguelgrc miguelgrc added the test-environment Deploy Opik adhoc environment label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

🔄 Test environment deployment process has started

Phase 1: Deploying base version 1.10.59-4806 (from main branch) if environment doesn't exist
Phase 2: Building new images from PR branch miguelg/OPIK-5628-clear-error-on-reconnect
Phase 3: Will deploy newly built version after build completes

You can monitor the progress here.

Copy link
Copy Markdown
Member

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miguelgrc miguelgrc merged commit 4b99def into main Apr 7, 2026
43 checks passed
@miguelgrc miguelgrc deleted the miguelg/OPIK-5628-clear-error-on-reconnect branch April 7, 2026 08:44
@CometActions
Copy link
Copy Markdown
Collaborator

Test environment is now available!

To configure additional Environment variables for your environment, run [Deploy Opik AdHoc Environment workflow] (https://github.com/comet-ml/comet-deployment/actions/workflows/deploy_opik_adhoc_env.yaml)

Access Information

The deployment has completed successfully and the version has been verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend test-environment Deploy Opik adhoc environment typescript *.ts *.tsx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants