Skip to content

[DND-843][HELM]Add custom podMetrics support to HPA template#6094

Merged
liyaka merged 2 commits intomainfrom
liya/DND-843-hpa-custom-metrics
Apr 7, 2026
Merged

[DND-843][HELM]Add custom podMetrics support to HPA template#6094
liyaka merged 2 commits intomainfrom
liya/DND-843-hpa-custom-metrics

Conversation

@liyaka
Copy link
Copy Markdown
Collaborator

@liyaka liyaka commented Apr 6, 2026

Details

  • Extend HPA template to support custom pod metrics via autoscaling.podMetrics
  • Enables scaling on Prometheus Adapter custom metrics (e.g. scoring_executor_queue_size)
  • Backwards compatible — no change if podMetrics is not set

Issues

DND-843

Usage

autoscaling:
  enabled: true
  podMetrics:
    - name: scoring_executor_queue_size
      averageValue: "100"

Testing

  • Helm template renders correctly with podMetrics configured
  • Helm template renders correctly without podMetrics (backwards compat)
  • HPA picks up custom metric from Prometheus Adapter on dev/prod

🤖 Generated with Claude Code

@liyaka liyaka requested review from a team as code owners April 6, 2026 20:24
@liyaka liyaka changed the title Add custom podMetrics support to HPA template [DND-843][HELM]Add custom podMetrics support to HPA template Apr 6, 2026
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 6, 2026
@comet-ml comet-ml deleted a comment from github-actions bot Apr 6, 2026
@comet-ml comet-ml deleted a comment from github-actions bot Apr 6, 2026
@comet-ml comet-ml deleted a comment from github-actions bot Apr 6, 2026
@comet-ml comet-ml deleted a comment from github-actions bot Apr 6, 2026
Copy link
Copy Markdown
Member

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

liyaka and others added 2 commits April 7, 2026 13:14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@liyaka liyaka force-pushed the liya/DND-843-hpa-custom-metrics branch from 99297be to dfe0eca Compare April 7, 2026 10:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

📋 PR Linter Failed

Missing Section. The description is missing the ## Change checklist section.


Missing Section. The description is missing the ## Documentation section.

@liyaka liyaka merged commit 84cab02 into main Apr 7, 2026
9 of 10 checks passed
@liyaka liyaka deleted the liya/DND-843-hpa-custom-metrics branch April 7, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants