Skip to content

[OPIK-5399] [FE] fix: pass search params from assistant sidebar navigate events to router#6099

Merged
awkoy merged 1 commit intomainfrom
fix/assistant-sidebar-navigate-search-params
Apr 7, 2026
Merged

[OPIK-5399] [FE] fix: pass search params from assistant sidebar navigate events to router#6099
awkoy merged 1 commit intomainfrom
fix/assistant-sidebar-navigate-search-params

Conversation

@awkoy
Copy link
Copy Markdown
Contributor

@awkoy awkoy commented Apr 7, 2026

Details

The assistant sidebar bridge now includes an optional search field on navigate events. Previously query params were embedded in the path string, but TanStack Router's navigate({ to }) ignores query params in the to option — they must be passed via the search option.

  • Adds search?: Record<string, string> to the SidebarEventMap navigate event type in assistant-sidebar.ts
  • Destructures { path, search } in the bridge emit handler
  • Passes search to router.navigate({ to, search }) so TanStack Router correctly applies query params

Companion PR: ollie-assist#150 — updates the SITEMAP to V2 project-scoped paths and sends search as a separate field in the NavigatePayload SSE event.

Issues

OPIK-5399

Testing

  • Navigate to a project's traces → URL should include ?logsType=traces
  • Navigate to experiments, agent-configuration → correct V2 project-scoped URLs
  • Navigate to workspace-level pages (projects, dashboards) → no search params, works as before

Change checklist

  • I have informed the relevant parties about this change
  • I have updated the relevant documentation
  • I have added tests to cover my changes

Documentation

No documentation changes needed — this is an internal bridge contract update between the assistant sidebar and the host app.

🤖 Generated with Claude Code

…o router

The assistant sidebar bridge now includes an optional `search` field on
navigate events. Previously query params were embedded in the path string,
but TanStack Router's navigate({ to }) ignores query params in the to
option — they must be passed via the search option.

- Add `search?: Record<string, string>` to SidebarEventMap navigate type
- Destructure { path, search } in the bridge emit handler
- Pass search to router.navigate({ to, search }) in navigateRef

Companion to ollie-assist PR that updates the SITEMAP and NavigatePayload.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@awkoy awkoy requested a review from a team as a code owner April 7, 2026 11:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

📋 PR Linter Failed

Invalid Title Format. Your PR title must include a ticket/issue number and may optionally include component tags ([FE], [BE], etc.).

  • Internal contributors: Open a JIRA ticket and link to it: [OPIK-xxxx] or [CUST-xxxx] or [DND-xxxx] or [DEV-xxxx] [COMPONENT] Your change
  • External contributors: Open a Github Issue and link to it via its number: [issue-xxxx] [COMPONENT] Your change
  • No ticket: Use [NA] [COMPONENT] Your change (Issues section not required)

Example: [issue-3108] [BE] [FE] Fix authentication bug or [OPIK-1234] Fix bug or [NA] Update README


Missing Section. The description is missing the ## Details section.


Missing Section. The description is missing the ## Change checklist section.


Missing Section. The description is missing the ## Issues section.


Missing Section. The description is missing the ## Testing section.


Missing Section. The description is missing the ## Documentation section.

@awkoy awkoy changed the title [FE] fix: pass search params from assistant sidebar navigate events to router [NA] [FE] fix: pass search params from assistant sidebar navigate events to router Apr 7, 2026
@awkoy awkoy changed the title [NA] [FE] fix: pass search params from assistant sidebar navigate events to router [OPIK-5399] [FE] fix: pass search params from assistant sidebar navigate events to router Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

📋 PR Linter Failed

Incomplete Issues Section. You must reference at least one GitHub issue (#xxxx), Jira ticket (OPIK-xxxx), CUST ticket (CUST-xxxx), DEV ticket (DEV-xxxx), or DND ticket (DND-xxxx) under the ## Issues section.

@awkoy awkoy merged commit 06f7ec4 into main Apr 7, 2026
11 of 13 checks passed
@awkoy awkoy deleted the fix/assistant-sidebar-navigate-search-params branch April 7, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants