Conversation
petrotiurin
approved these changes
Apr 7, 2026
Contributor
petrotiurin
left a comment
There was a problem hiding this comment.
sdk looks good, thanks!
andrescrz
added a commit
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Add test coverage for the
excludeparameter onsearch_traces, as requested in PR #6098 review comments. This includes TypeScript SDK unit tests for theexcludeoption pass-through and E2E tests that verify the stream search endpoint correctly excludes feedback scores from the response while preserving all other trace fields.Changes:
excludeto existing option-override and integration tests, plus a standalone multi-field exclude test (3 modifications, 1 new test)/search-tracesFlask endpoint wrappingclient.search_traces()with exclude support, and correspondingsearchTracesmethod on the TypeScript test helper clienttrace-search.spec.tswith control/treatment steps — verifies full trace payload (name, input, output, tags, metadata, feedback scores with values and source) then confirmsexclude=["feedback_scores"]removes only scoresChange checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
Testing
npx vitest run tests/unit/client/client-searchTraces.test.ts— 16/16 passpre-commit run --files <changed files>— cleanopik.sh+ Flask test helper). Not run locally — to be validated by CI (@fullregression @tracingsuite)Documentation
N/A