[OPIK-5707] [BE] Fix eval suite dataset storing empty data for non-object trace input#6109
Merged
LifeXplorer merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
…ject trace input Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
apps/opik-backend/src/main/java/com/comet/opik/domain/DatasetItemService.java
Show resolved
Hide resolved
Contributor
Backend Tests - Integration Group 16 15 files ± 0 15 suites ±0 5m 1s ⏱️ -22s For more details on these errors, see this check. Results for commit 956e78b. ± Comparison against base commit ff0a7d1. |
thiagohora
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When adding a trace to an evaluation suite dataset, if the trace input is a JSON array (e.g. chat messages
[{"role":"user","content":"hello"}]) or a scalar value,filterDataForDatasetType()discards the input entirely and stores{}as the dataset item data.The fix adds a third branch: non-object inputs (array, string, number, boolean) are now wrapped under an
"input"key, preserving the data while maintaining theMap<String, JsonNode>type constraint. Object inputs continue to be unwrapped as top-level keys (no regression).Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: yes
Testing
mvn test -Dtest=DatasetItemServiceFilterDataTest— all 9 parameterized tests pass"data":{}before fix"data":{"input":[{"role":"user","content":"hello"}]}Documentation
N/A