[OPIK-5664] [E2E] fix: replace span.end() with end_time at creation#6139
Merged
alexkuzmik merged 1 commit intomainfrom Apr 8, 2026
Merged
[OPIK-5664] [E2E] fix: replace span.end() with end_time at creation#6139alexkuzmik merged 1 commit intomainfrom
alexkuzmik merged 1 commit intomainfrom
Conversation
Pass end_time directly to span constructor instead of calling .end() shortly after creation. With batching enabled, .end() sends an update that can arrive before the batched create is flushed, causing data loss. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
bot
added
python
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Replace
span.end()calls withend_timepassed at span creation time in the E2E test helper service. With batching enabled (now the default), calling.end()shortly after creation sends an update message that can arrive at the server before the batched create request is flushed, causing the update to be silently dropped (data loss).Three callsites fixed in
tests_end_to_end/test-helper-service/routes/traces.py:create-traces-clientendpointcreate-traces-with-spans-clientendpointcreate-trace-with-attachmentendpointChange checklist
Issues
Testing
Existing E2E tests cover these endpoints — the behavior is unchanged (spans still get an
end_time), just set at creation instead of via a separate update message.Documentation
N/A